github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-21 10:41:50 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2339] [MERGED] fix(cli): make user deletion confirmation check Windows compatible #5612

New Issue
Closed
opened 2026-04-16 13:44:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:44:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2339
Author: @chau-intl
Created: 3/3/2026
Status: ✅ Merged
Merged: 3/5/2026
Merged by: @kolaente

Base: main ← Head: main

📝 Commits (4)

  • cd154fc Updated CLI delete user method to be Windows compatible.
  • c3bc69f Updated the delete method to use trimming to handle newline characters
  • 0ef5ea0 Merge branch 'main' into main
  • a093a52 fix: remove trailing whitespace to pass gofmt lint

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 pkg/cmd/user.go (+5 -1)

📄 Description

The current implementation of the user confirmation when deleting a user using the CLI seems to favour Linux. On Windows the command adds "\r\n" to the user input while Linux only adds "\n".

I have added an extra check to the confirmation, but GO is a new language for me, so there is probably a much better way to do this.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2339 **Author:** [@chau-intl](https://github.com/chau-intl) **Created:** 3/3/2026 **Status:** ✅ Merged **Merged:** 3/5/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (4) - [`cd154fc`](https://github.com/go-vikunja/vikunja/commit/cd154fc39ccf26c8abdf9325b72d155aeeb70a9b) Updated CLI delete user method to be Windows compatible. - [`c3bc69f`](https://github.com/go-vikunja/vikunja/commit/c3bc69f7f124682a4758ff4531da3b5f24fd8758) Updated the delete method to use trimming to handle newline characters - [`0ef5ea0`](https://github.com/go-vikunja/vikunja/commit/0ef5ea0e30d406e513c50b5dc71766a14a57ba4b) Merge branch 'main' into main - [`a093a52`](https://github.com/go-vikunja/vikunja/commit/a093a52a283dc0467555d272aa1c4e00d253698e) fix: remove trailing whitespace to pass gofmt lint ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/cmd/user.go` (+5 -1) </details> ### 📄 Description The current implementation of the user confirmation when deleting a user using the CLI seems to favour Linux. On Windows the <ENTER> command adds "\r\n" to the user input while Linux only adds "\n". I have added an extra check to the confirmation, but GO is a new language for me, so there is probably a much better way to do this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:44:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5612
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?