github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-26 22:11:48 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2313] [MERGED] fix(deps): use forked afero-s3 to fix S3 read performance regression #5599

New Issue
Closed
opened 2026-04-16 13:43:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:43:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2313
Author: @maggch97
Created: 2/27/2026
Status: ✅ Merged
Merged: 3/3/2026
Merged by: @kolaente

Base: main ← Head: fix/s3-read-performance

📝 Commits (1)

  • 8698134 fix(deps): use forked afero-s3 to fix S3 read performance regression

📊 Changes

2 files changed (+61 additions, -59 deletions)

View changed files

📝 go.mod (+21 -19)
📝 go.sum (+40 -40)

📄 Description

The upstream afero-s3 library has a severe performance regression where every Read() call opens a new HTTP connection to S3, resulting in hundreds of requests for sequential reads (e.g. ~320 requests for a 10MB file with 32KB buffers instead of 1).

This temporarily replaces afero-s3 with a fork that fixes the issue by requesting from the current offset to end-of-file when opening a read stream, and properly closing the stream on Seek().

Upstream PR: https://github.com/fclairamb/afero-s3/pull/938 This replace directive should be removed once the upstream PR is merged and a new version is released.

all releases after Jan 15(843ef7218a ) are affected

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2313 **Author:** [@maggch97](https://github.com/maggch97) **Created:** 2/27/2026 **Status:** ✅ Merged **Merged:** 3/3/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix/s3-read-performance` --- ### 📝 Commits (1) - [`8698134`](https://github.com/go-vikunja/vikunja/commit/86981346fb2058064cb8b0633b4016dd161c0271) fix(deps): use forked afero-s3 to fix S3 read performance regression ### 📊 Changes **2 files changed** (+61 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `go.mod` (+21 -19) 📝 `go.sum` (+40 -40) </details> ### 📄 Description The upstream afero-s3 library has a severe performance regression where every Read() call opens a new HTTP connection to S3, resulting in hundreds of requests for sequential reads (e.g. ~320 requests for a 10MB file with 32KB buffers instead of 1). This temporarily replaces afero-s3 with a fork that fixes the issue by requesting from the current offset to end-of-file when opening a read stream, and properly closing the stream on Seek(). Upstream PR: https://github.com/fclairamb/afero-s3/pull/938 This replace directive should be removed once the upstream PR is merged and a new version is released. all releases after Jan 15(https://github.com/go-vikunja/vikunja/commit/843ef7218a141ee23d25f99f46243bd4598f59fa ) are affected --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:43:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5599
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?