github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-21 18:53:07 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2056] [MERGED] feat: merge duplicate notifications #5439

New Issue
Closed
opened 2026-04-16 13:38:24 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:38:24 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2056
Author: @kolaente
Created: 1/6/2026
Status: ✅ Merged
Merged: 1/6/2026
Merged by: @kolaente

Base: main ← Head: feat-merge-duplicate-notificiations

📝 Commits (2)

  • acc1189 feat: merge duplicat notifications
  • 62887a7 fix: use string text for duplicate detection and add Playwright test

📊 Changes

3 files changed (+54 additions, -8 deletions)

View changed files

📝 frontend/src/components/misc/Notification.vue (+17 -5)
📝 frontend/src/message/index.ts (+7 -3)
➕ frontend/tests/e2e/misc/notifications.spec.ts (+30 -0)

📄 Description

closes https://github.com/go-vikunja/vikunja/pull/971

Summary

Incorporates the changes from https://github.com/go-vikunja/vikunja/pull/971 with improvements:

  • Enables duplicate notification merging using the ignoreDuplicates prop from vue3-notification
  • Shows a count (×N) when notifications are merged
  • Fix: Uses string text instead of arrays so duplicate detection actually works (vue3-notification uses strict equality)
  • Fix: Moves actions under data in error notifications to match template's item.data?.actions
  • Fix: Updates template to handle both string and array text for backwards compatibility
  • Replaces Cypress test with Playwright e2e test

Test plan

  • Playwright test verifies duplicate notifications are merged and show correct count

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2056 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 1/6/2026 **Status:** ✅ Merged **Merged:** 1/6/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `feat-merge-duplicate-notificiations` --- ### 📝 Commits (2) - [`acc1189`](https://github.com/go-vikunja/vikunja/commit/acc11898d06c962e916f1c6c7ca0161de9b34d2e) feat: merge duplicat notifications - [`62887a7`](https://github.com/go-vikunja/vikunja/commit/62887a7bee7b6afc8ab8e7669e35f166037ad56c) fix: use string text for duplicate detection and add Playwright test ### 📊 Changes **3 files changed** (+54 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/misc/Notification.vue` (+17 -5) 📝 `frontend/src/message/index.ts` (+7 -3) ➕ `frontend/tests/e2e/misc/notifications.spec.ts` (+30 -0) </details> ### 📄 Description closes https://github.com/go-vikunja/vikunja/pull/971 ## Summary Incorporates the changes from https://github.com/go-vikunja/vikunja/pull/971 with improvements: - Enables duplicate notification merging using the `ignoreDuplicates` prop from vue3-notification - Shows a count (×N) when notifications are merged - **Fix**: Uses string text instead of arrays so duplicate detection actually works (vue3-notification uses strict equality) - **Fix**: Moves `actions` under `data` in error notifications to match template's `item.data?.actions` - **Fix**: Updates template to handle both string and array text for backwards compatibility - Replaces Cypress test with Playwright e2e test ## Test plan - [x] Playwright test verifies duplicate notifications are merged and show correct count --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:38:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5439
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?