[PR #1963] [MERGED] fix(editor): make url bar appear at the correct position when scrolling #5367

Closed
opened 2026-04-16 13:35:41 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1963
Author: @kolaente
Created: 12/10/2025
Status: Merged
Merged: 12/10/2025
Merged by: @kolaente

Base: mainHead: fix-url-input


📝 Commits (4)

  • a557547 fix: floating url bar position
  • 911c70d fix: make the url toolbar move when scrolling
  • 998a19d fix type safety
  • 66c4905 chore: add tests

📊 Changes

2 files changed (+197 additions, -14 deletions)

View changed files

📝 frontend/src/helpers/inputPrompt.ts (+49 -14)
📝 frontend/tests/e2e/task/task.spec.ts (+148 -0)

📄 Description

Resolves https://github.com/go-vikunja/vikunja/issues/1899

Summary by CodeRabbit

  • Bug Fixes
    • Fixed input prompt popup positioning to remain correctly placed when scrolling the page.
    • Improved popup cleanup and event listener management when closed.

✏️ Tip: You can customize this high-level summary in your review settings.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1963 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 12/10/2025 **Status:** ✅ Merged **Merged:** 12/10/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-url-input` --- ### 📝 Commits (4) - [`a557547`](https://github.com/go-vikunja/vikunja/commit/a5575473696876c03019ab26d7623ae845aeee5f) fix: floating url bar position - [`911c70d`](https://github.com/go-vikunja/vikunja/commit/911c70da4553e65270de83b73be09c28caaaefb9) fix: make the url toolbar move when scrolling - [`998a19d`](https://github.com/go-vikunja/vikunja/commit/998a19d42abda1c7afc33a56e8bfc473b5020b33) fix type safety - [`66c4905`](https://github.com/go-vikunja/vikunja/commit/66c4905c2e4444f1f79533a8fc574c2a05a916fa) chore: add tests ### 📊 Changes **2 files changed** (+197 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/helpers/inputPrompt.ts` (+49 -14) 📝 `frontend/tests/e2e/task/task.spec.ts` (+148 -0) </details> ### 📄 Description Resolves https://github.com/go-vikunja/vikunja/issues/1899 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Fixed input prompt popup positioning to remain correctly placed when scrolling the page. * Improved popup cleanup and event listener management when closed. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:35:41 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5367