github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-07-20 21:14:30 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #1959] [MERGED] fix: prevent emoji picker from closing when clicking search input #5364

New Issue
Closed
opened 2026-04-16 13:35:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:35:33 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1959
Author: @kolaente
Created: 12/9/2025
Status: ✅ Merged
Merged: 12/9/2025
Merged by: @kolaente

Base: main ← Head: kolaente/fix-emoji-search-close

📝 Commits (1)

  • 4fad658 fix: prevent emoji picker from closing when clicking search input

📊 Changes

2 files changed (+7 additions, -16 deletions)

View changed files

📝 frontend/src/components/input/Reactions.vue (+3 -3)
📝 frontend/src/helpers/closeWhenClickedOutside.ts (+4 -13)

📄 Description

Resolves https://community.vikunja.io/t/cannot-search-for-reaction-emoji/4207/1

Summary

  • Fixes the emoji reaction picker closing immediately when clicking inside the search box
  • The issue occurred because vuemoji-picker wraps emoji-picker-element which uses Shadow DOM
  • The closeWhenClickedOutside helper was using parentElement traversal which doesn't cross shadow boundaries

Changes

  • Updated closeWhenClickedOutside to use event.composedPath() which properly includes elements inside Shadow DOM
  • Updated Reactions.vue to pass the actual DOM element ($el) instead of the Vue component instance

Test plan

  • Open a task detail view
  • Click the emoji reaction button (smiley face) to open the picker
  • Click inside the search box
  • Verify the picker stays open and you can type to search
  • Verify clicking outside the picker still closes it
  • Test in both Firefox and Chromium-based browsers

🤖 Generated with Claude Code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1959 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 12/9/2025 **Status:** ✅ Merged **Merged:** 12/9/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `kolaente/fix-emoji-search-close` --- ### 📝 Commits (1) - [`4fad658`](https://github.com/go-vikunja/vikunja/commit/4fad65860129140d80971c98a13cf3219598ceb4) fix: prevent emoji picker from closing when clicking search input ### 📊 Changes **2 files changed** (+7 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/input/Reactions.vue` (+3 -3) 📝 `frontend/src/helpers/closeWhenClickedOutside.ts` (+4 -13) </details> ### 📄 Description Resolves https://community.vikunja.io/t/cannot-search-for-reaction-emoji/4207/1 ## Summary - Fixes the emoji reaction picker closing immediately when clicking inside the search box - The issue occurred because `vuemoji-picker` wraps `emoji-picker-element` which uses Shadow DOM - The `closeWhenClickedOutside` helper was using `parentElement` traversal which doesn't cross shadow boundaries ## Changes - Updated `closeWhenClickedOutside` to use `event.composedPath()` which properly includes elements inside Shadow DOM - Updated `Reactions.vue` to pass the actual DOM element (`$el`) instead of the Vue component instance ## Test plan - [ ] Open a task detail view - [ ] Click the emoji reaction button (smiley face) to open the picker - [ ] Click inside the search box - [ ] Verify the picker stays open and you can type to search - [ ] Verify clicking outside the picker still closes it - [ ] Test in both Firefox and Chromium-based browsers 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:35:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5364