github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 19:47:47 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #1845] [CLOSED] fix(editor): preserve consecutive whitespace in comments in TipTap #5272

New Issue
Closed
opened 2026-04-16 13:32:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:32:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1845
Author: @maggch97
Created: 11/19/2025
Status: ❌ Closed

Base: main ← Head: user/weijiezhao/whitespaceincomments

📝 Commits (2)

  • 3057740 fix(editor): preserve consecutive whitespace in comments in TipTap
  • 85a83ed Merge branch 'main' into user/weijiezhao/whitespaceincomments

📊 Changes

1 file changed (+13 additions, -4 deletions)

View changed files

📝 frontend/src/components/input/editor/TipTap.vue (+13 -4)

📄 Description

fix: https://github.com/go-vikunja/vikunja/issues/1844
Ensure multiple spaces in comment content are no longer collapsed when editing/saving by:

  • Adding SetContentOptions with parseOptions.preserveWhitespace = 'full'
  • Applying those options to all setContent calls (initial load, exit edit mode, post-upload cleanup)
  • Enabling preserveWhitespace in editor parseOptions

Previously, repeated spaces were normalized away after setContent(false), causing comments with deliberate spacing to be altered unexpectedly.

No behavioral changes beyond whitespace retention; renders identical except space fidelity.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1845 **Author:** [@maggch97](https://github.com/maggch97) **Created:** 11/19/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `user/weijiezhao/whitespaceincomments` --- ### 📝 Commits (2) - [`3057740`](https://github.com/go-vikunja/vikunja/commit/30577403c6014b9bf8a2ac6561719b559c87c194) fix(editor): preserve consecutive whitespace in comments in TipTap - [`85a83ed`](https://github.com/go-vikunja/vikunja/commit/85a83edb2be530cb575d55f2dfc291d4256c29a1) Merge branch 'main' into user/weijiezhao/whitespaceincomments ### 📊 Changes **1 file changed** (+13 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/input/editor/TipTap.vue` (+13 -4) </details> ### 📄 Description fix: https://github.com/go-vikunja/vikunja/issues/1844 Ensure multiple spaces in comment content are no longer collapsed when editing/saving by: - Adding SetContentOptions with parseOptions.preserveWhitespace = 'full' - Applying those options to all setContent calls (initial load, exit edit mode, post-upload cleanup) - Enabling preserveWhitespace in editor parseOptions Previously, repeated spaces were normalized away after setContent(false), causing comments with deliberate spacing to be altered unexpectedly. No behavioral changes beyond whitespace retention; renders identical except space fidelity. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:32:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5272
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?