github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-08 21:08:04 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #1414] [MERGED] fix(user): do not reject 2fa for local users #4946

New Issue
Closed
opened 2026-04-16 13:22:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:22:01 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1414
Author: @kolaente
Created: 9/4/2025
Status: ✅ Merged
Merged: 9/4/2025
Merged by: @kolaente

Base: main ← Head: fix/2fa-local-user

📝 Commits (2)

  • f7aea32 fix(user): do not reject 2fa for local users
  • ef9fb8e refactor: use helper function to check user local

📊 Changes

3 files changed (+80 additions, -47 deletions)

View changed files

📝 pkg/routes/api/v1/user_totp.go (+25 -47)
📝 pkg/webtests/integrations.go (+2 -0)
➕ pkg/webtests/user_totp_test.go (+53 -0)

📄 Description

Resolves https://github.com/go-vikunja/vikunja/issues/1402

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1414 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 9/4/2025 **Status:** ✅ Merged **Merged:** 9/4/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix/2fa-local-user` --- ### 📝 Commits (2) - [`f7aea32`](https://github.com/go-vikunja/vikunja/commit/f7aea32a1a669c827223b4ddfb60273b2c64bb7f) fix(user): do not reject 2fa for local users - [`ef9fb8e`](https://github.com/go-vikunja/vikunja/commit/ef9fb8e6b2445e9a4a38039463bd8e9523c6bb18) refactor: use helper function to check user local ### 📊 Changes **3 files changed** (+80 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `pkg/routes/api/v1/user_totp.go` (+25 -47) 📝 `pkg/webtests/integrations.go` (+2 -0) ➕ `pkg/webtests/user_totp_test.go` (+53 -0) </details> ### 📄 Description Resolves https://github.com/go-vikunja/vikunja/issues/1402 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:22:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#4946
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?