github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 11:37:49 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #1119] [MERGED] fix: don't panic when using api token when not correctly put into context #4714

New Issue
Closed
opened 2026-04-16 13:13:47 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:13:47 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1119
Author: @kolaente
Created: 7/14/2025
Status: ✅ Merged
Merged: 7/15/2025
Merged by: @kolaente

Base: main ← Head: codex/analyze-and-fix-internal-server-error

📝 Commits (2)

  • 381bd23 fix(api): resolve panic when using api tokens
  • f121d1b refactor

📊 Changes

3 files changed (+49 additions, -1 deletions)

View changed files

📝 pkg/routes/api_tokens.go (+7 -0)
📝 pkg/user/error.go (+27 -0)
📝 pkg/user/user.go (+15 -1)

📄 Description

Summary

  • prevent panic by loading the token owner into request context
  • use the context user object in GetCurrentUser

Testing

  • mage lint:fix

https://chatgpt.com/codex/tasks/task_e_687577d0cec88322a07b3eabd96decf9

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1119 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 7/14/2025 **Status:** ✅ Merged **Merged:** 7/15/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `codex/analyze-and-fix-internal-server-error` --- ### 📝 Commits (2) - [`381bd23`](https://github.com/go-vikunja/vikunja/commit/381bd235b956d35bd3f92cc013239c790233d19a) fix(api): resolve panic when using api tokens - [`f121d1b`](https://github.com/go-vikunja/vikunja/commit/f121d1bae0724f1d3edea660f986ea39b8ba9888) refactor ### 📊 Changes **3 files changed** (+49 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/routes/api_tokens.go` (+7 -0) 📝 `pkg/user/error.go` (+27 -0) 📝 `pkg/user/user.go` (+15 -1) </details> ### 📄 Description ## Summary - prevent panic by loading the token owner into request context - use the context user object in `GetCurrentUser` ## Testing - `mage lint:fix` ------ https://chatgpt.com/codex/tasks/task_e_687577d0cec88322a07b3eabd96decf9 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:13:47 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#4714
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?