github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-07-11 21:52:47 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #1046] [MERGED] feat: rebuild filter query input #4647

New Issue
Closed
opened 2026-04-16 13:11:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:11:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1046
Author: @kolaente
Created: 6/28/2025
Status: ✅ Merged
Merged: 8/11/2025
Merged by: @kolaente

Base: main ← Head: feature/rewrite-filter-input

📝 Commits (9)

  • a6a44ac feat(filter): rebuild filter input component
  • 040b7e2 fix(filter): don't treat ' ' as label value
  • 669668d fix(filter): highlight multiple labels multiple times
  • 58e8268 fix(filter): don't treat word value in filter value as operator
  • 06cfb46 feat(filter): automatically focus filter input when opening filter popup
  • 4f37d4a fix(filter): correctly replace quoted values
  • 8e39708 feat(filter): use new filter input component in view edit
  • 368071e chore(filter): remove old filter input component
  • c5e0196 chore(filter): move FilterInputDocs component

📊 Changes

17 files changed (+1620 additions, -483 deletions)

View changed files

📝 frontend/src/components/date/DatepickerWithValues.vue (+3 -0)
📝 frontend/src/components/input/AutocompleteDropdown.vue (+1 -0)
➕ frontend/src/components/input/filter/FilterAutocomplete.ts (+493 -0)
➕ frontend/src/components/input/filter/FilterCommandsList.vue (+174 -0)
➕ frontend/src/components/input/filter/FilterInput.vue (+313 -0)
📝 frontend/src/components/input/filter/FilterInputDocs.vue (+0 -0)
➕ frontend/src/components/input/filter/highlighter.ts (+327 -0)
📝 frontend/src/components/misc/Popup.vue (+10 -1)
➖ frontend/src/components/project/partials/FilterInput.story.vue (+0 -22)
➖ frontend/src/components/project/partials/FilterInput.vue (+0 -415)
📝 frontend/src/components/project/partials/FilterPopup.vue (+12 -2)
📝 frontend/src/components/project/partials/Filters.vue (+16 -13)
📝 frontend/src/components/project/views/ViewEditForm.vue (+19 -10)
📝 frontend/src/helpers/filters.test.ts (+176 -0)
📝 frontend/src/helpers/filters.ts (+74 -19)
📝 frontend/src/i18n/lang/en.json (+1 -0)
📝 frontend/src/views/tasks/TaskDetailView.vue (+1 -1)

📄 Description

This rebuilds the filter input to use TipTap, which makes the highlighting a lot smoother and less buggy.

Resolves https://github.com/go-vikunja/vikunja/issues/552
Resolves https://github.com/go-vikunja/vikunja/issues/743

  • https://github.com/go-vikunja/vikunja/issues/552
  • https://github.com/go-vikunja/vikunja/issues/743
  • When entering a query like labels = there is an empty before the =
  • Filtering by multiple values with comma should create multiple comma-separated values instead of one label1, label2 value
  • When a label contains in, that part of the label is treated as the operator instead of part of the label
  • When a label starts with l, the l of the labels = query is treated as value instead and highlighted
  • Remove the debug filter code block below the input
  • Use the new filter in project view settings
  • Remove old FilterInput component and related, now unused function

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1046 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 6/28/2025 **Status:** ✅ Merged **Merged:** 8/11/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `feature/rewrite-filter-input` --- ### 📝 Commits (9) - [`a6a44ac`](https://github.com/go-vikunja/vikunja/commit/a6a44aca2b3acfa74fce6c9ca789866a35d11d6b) feat(filter): rebuild filter input component - [`040b7e2`](https://github.com/go-vikunja/vikunja/commit/040b7e22e12658c71bae0dc3b40b767711e1f504) fix(filter): don't treat ' ' as label value - [`669668d`](https://github.com/go-vikunja/vikunja/commit/669668d961482ee63a13bc9623631af61a32543a) fix(filter): highlight multiple labels multiple times - [`58e8268`](https://github.com/go-vikunja/vikunja/commit/58e82684acf7870ba0c5832e04551ca8d418aa37) fix(filter): don't treat word value in filter value as operator - [`06cfb46`](https://github.com/go-vikunja/vikunja/commit/06cfb461f18995b714ad42e822ee85ae78a6ca49) feat(filter): automatically focus filter input when opening filter popup - [`4f37d4a`](https://github.com/go-vikunja/vikunja/commit/4f37d4af1a9d5ebfbc0f1378fc38b750c3f498cf) fix(filter): correctly replace quoted values - [`8e39708`](https://github.com/go-vikunja/vikunja/commit/8e397088d11c9d546d419707af41df7b3477ab01) feat(filter): use new filter input component in view edit - [`368071e`](https://github.com/go-vikunja/vikunja/commit/368071e726142d3b96ed01169f1c56bc82d07e46) chore(filter): remove old filter input component - [`c5e0196`](https://github.com/go-vikunja/vikunja/commit/c5e0196f6c36b7e004b778fa848ea7a7634897a0) chore(filter): move FilterInputDocs component ### 📊 Changes **17 files changed** (+1620 additions, -483 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/date/DatepickerWithValues.vue` (+3 -0) 📝 `frontend/src/components/input/AutocompleteDropdown.vue` (+1 -0) ➕ `frontend/src/components/input/filter/FilterAutocomplete.ts` (+493 -0) ➕ `frontend/src/components/input/filter/FilterCommandsList.vue` (+174 -0) ➕ `frontend/src/components/input/filter/FilterInput.vue` (+313 -0) 📝 `frontend/src/components/input/filter/FilterInputDocs.vue` (+0 -0) ➕ `frontend/src/components/input/filter/highlighter.ts` (+327 -0) 📝 `frontend/src/components/misc/Popup.vue` (+10 -1) ➖ `frontend/src/components/project/partials/FilterInput.story.vue` (+0 -22) ➖ `frontend/src/components/project/partials/FilterInput.vue` (+0 -415) 📝 `frontend/src/components/project/partials/FilterPopup.vue` (+12 -2) 📝 `frontend/src/components/project/partials/Filters.vue` (+16 -13) 📝 `frontend/src/components/project/views/ViewEditForm.vue` (+19 -10) 📝 `frontend/src/helpers/filters.test.ts` (+176 -0) 📝 `frontend/src/helpers/filters.ts` (+74 -19) 📝 `frontend/src/i18n/lang/en.json` (+1 -0) 📝 `frontend/src/views/tasks/TaskDetailView.vue` (+1 -1) </details> ### 📄 Description This rebuilds the filter input to use TipTap, which makes the highlighting a lot smoother and less buggy. Resolves https://github.com/go-vikunja/vikunja/issues/552 Resolves https://github.com/go-vikunja/vikunja/issues/743 - [x] https://github.com/go-vikunja/vikunja/issues/552 - [x] https://github.com/go-vikunja/vikunja/issues/743 - [x] When entering a query like `labels =` there is an empty ` ` before the `=` - [x] Filtering by multiple values with comma should create multiple comma-separated values instead of one `label1, label2` value - [x] When a label contains `in`, that part of the label is treated as the operator instead of part of the label - [x] When a label starts with `l`, the `l` of the `labels =` query is treated as value instead and highlighted - [x] Remove the debug filter code block below the input - [x] Use the new filter in project view settings - [x] Remove old `FilterInput` component and related, now unused function --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:11:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#4647
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?