github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-07-16 14:52:35 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

WIP: feat: add zod schemas #463

New Issue
Closed
opened 2025-11-01 20:56:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-01 20:56:32 -05:00
Owner
Copy Link

Originally created by @vikunja-bot on GitHub (Apr 1, 2025).

Original issue by @kolaente on 2024-02-08T13:16:20.000Z

Cherry-picked from https://kolaente.dev/vikunja/frontend/pulls/2225

Original issue on Gitea

dpschen commented on 2025-01-14T14:47:16.000Z:

@konrad Do you remember what exactly you did when rebasing?

Asking mostly because in this PR there are a lot more changes than in the original PR. The original PR added the zod schemas (aka new files) that were not used yet and added two dependencies (zod and validator.js for some validation). See also the commits.

The idea was to iteratively switch to zod. If you want I can "rebase" the original PR, but I would need to know what else changed here.

Tbh I would actually redo the changes since that seems simpler:

  1. add the new schema files to the modelSchema folder
  2. add the dependencies
  3. adjust model changes since the PR

@kolaente commented on 2025-01-14T16:52:49.000Z:

IIRC I tried to apply the changes that I did when merging the frontend and api repos.

dpschen commented on 2025-01-16T11:51:44.000Z:

IIRC I tried to apply the changes that I did when merging the frontend and api repos.
I realized that there were just some additional commits that added, that were already part of the main branch. When I rebased this branch they vanished.

Originally created by @vikunja-bot on GitHub (Apr 1, 2025). _Original issue by @kolaente on 2024-02-08T13:16:20.000Z_ Cherry-picked from https://kolaente.dev/vikunja/frontend/pulls/2225 [Original issue on Gitea](https://kolaente.dev/vikunja/vikunja/issues/2093) --- _**dpschen** commented on 2025-01-14T14:47:16.000Z_: @konrad Do you remember what exactly you did when rebasing? Asking mostly because in this PR there are a lot more changes than in the original PR. The original PR added the zod schemas (aka new files) that were not used yet and added two dependencies (zod and validator.js for some validation). See also [the commits](https://kolaente.dev/vikunja/frontend/pulls/2225/commits). The idea was to iteratively switch to zod. If you want I can "rebase" the original PR, but I would need to know what else changed here. Tbh I would actually redo the changes since that seems simpler: 1. add the new schema files to the `modelSchema` folder 2. add the dependencies 3. adjust model changes since the PR --- _**@kolaente** commented on 2025-01-14T16:52:49.000Z_: IIRC I tried to apply the changes that I did when merging the frontend and api repos. --- _**dpschen** commented on 2025-01-16T11:51:44.000Z_: > IIRC I tried to apply the changes that I did when merging the frontend and api repos. I realized that there were just some additional commits that added, that were already part of the main branch. When I rebased this branch they vanished.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#463
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?