github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 03:27:53 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #1007] [MERGED] fix(kanban): make bucket query fixed per-view #4611

New Issue
Closed
opened 2026-04-16 13:10:24 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:10:24 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1007
Author: @kolaente
Created: 6/24/2025
Status: ✅ Merged
Merged: 6/25/2025
Merged by: @kolaente

Base: main ← Head: codex/modify-task_search.go-for-cross-view-buckets

📝 Commits (4)

  • 4960aed test: ensure kanban tasks unique per bucket
  • 7c5e48d fix: fallback join when view id missing
  • 9ae750f test: set view id for task bucket factories
  • abd9d82 fix: indention

📊 Changes

7 files changed (+83 additions, -2 deletions)

View changed files

📝 frontend/cypress/e2e/task/task.spec.ts (+6 -0)
📝 pkg/models/kanban.go (+1 -0)
📝 pkg/models/task_collection.go (+4 -0)
📝 pkg/models/task_position.go (+1 -0)
📝 pkg/models/task_search.go (+14 -2)
➕ pkg/models/task_search_test.go (+56 -0)
📝 pkg/models/tasks.go (+1 -0)

📄 Description

Related to https://github.com/go-vikunja/vikunja/issues/398

Summary

  • pass view ID through task search options
  • join task_buckets with view filter
  • ensure view ID is set when searching tasks for a view
  • add regression test for bucket view filtering

Testing

  • mage lint:fix
  • mage test:feature

https://chatgpt.com/codex/tasks/task_e_685a6eea39708322bd886c6d999941c9
https://chatgpt.com/codex/tasks/task_e_6849cdbafb648322a21cd9c0a73e0d9f

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1007 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 6/24/2025 **Status:** ✅ Merged **Merged:** 6/25/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `codex/modify-task_search.go-for-cross-view-buckets` --- ### 📝 Commits (4) - [`4960aed`](https://github.com/go-vikunja/vikunja/commit/4960aedc4cfd6dced6d3aaad13c3002174653964) test: ensure kanban tasks unique per bucket - [`7c5e48d`](https://github.com/go-vikunja/vikunja/commit/7c5e48de2440024a830294154b77bc61bea7704a) fix: fallback join when view id missing - [`9ae750f`](https://github.com/go-vikunja/vikunja/commit/9ae750fc28f11381cab3e81d2ee70ebd00af858d) test: set view id for task bucket factories - [`abd9d82`](https://github.com/go-vikunja/vikunja/commit/abd9d8292d0a123f2c8274e5f51cefe2a88592d0) fix: indention ### 📊 Changes **7 files changed** (+83 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/cypress/e2e/task/task.spec.ts` (+6 -0) 📝 `pkg/models/kanban.go` (+1 -0) 📝 `pkg/models/task_collection.go` (+4 -0) 📝 `pkg/models/task_position.go` (+1 -0) 📝 `pkg/models/task_search.go` (+14 -2) ➕ `pkg/models/task_search_test.go` (+56 -0) 📝 `pkg/models/tasks.go` (+1 -0) </details> ### 📄 Description Related to https://github.com/go-vikunja/vikunja/issues/398 ## Summary - pass view ID through task search options - join `task_buckets` with view filter - ensure view ID is set when searching tasks for a view - add regression test for bucket view filtering ## Testing - `mage lint:fix` - `mage test:feature` ------ https://chatgpt.com/codex/tasks/task_e_685a6eea39708322bd886c6d999941c9 https://chatgpt.com/codex/tasks/task_e_6849cdbafb648322a21cd9c0a73e0d9f --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:10:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#4611
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?