Filter pop-up cannot be dismissed with Esc when a text or dropdown field has focus #452

Closed
opened 2025-11-01 20:56:23 -05:00 by GiteaMirror · 1 comment
Owner

Originally created by @vikunja-bot on GitHub (Apr 1, 2025).

Original issue by SteveDinn on 2023-05-05T14:54:22.000Z

Description

  • Click the Filters button to bring up the Filters pop-up.
  • Set the focused control to be any of the text fields or drop downs.
  • Hit Esc. to your heart's content, but nothing happens.

Reproduced on https://try.vikunja.io.

Vikunja Frontend Version

0.20.5+250-b25c5ff547

Vikunja API Version

v0.20.4+107-9c66b473dd

Browser and version

Firefox 112.0.2 (64-bit) Windows 10

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

No response

Original issue on Gitea


@kolaente commented on 2023-05-06T16:04:05.000Z:

I feel like that's a problem all modals have.

@dpschen Didn't we start a fix for this already somewhere?


@kolaente commented on 2023-05-06T16:05:26.000Z:

I think what we're looking for is the dialog element?

Originally created by @vikunja-bot on GitHub (Apr 1, 2025). _Original issue by SteveDinn on 2023-05-05T14:54:22.000Z_ ### Description * Click the Filters button to bring up the Filters pop-up. * Set the focused control to be any of the text fields or drop downs. * Hit Esc. to your heart's content, but nothing happens. Reproduced on [https://try.vikunja.io](https://try.vikunja.io). ### Vikunja Frontend Version 0.20.5+250-b25c5ff547 ### Vikunja API Version v0.20.4+107-9c66b473dd ### Browser and version Firefox 112.0.2 (64-bit) Windows 10 ### Can you reproduce the bug on the Vikunja demo site? Yes ### Screenshots _No response_ [Original issue on Gitea](https://kolaente.dev/vikunja/vikunja/issues/2052) --- _**@kolaente** commented on 2023-05-06T16:04:05.000Z_: I feel like that's a problem all modals have. @dpschen Didn't we start a fix for this already somewhere? --- _**@kolaente** commented on 2023-05-06T16:05:26.000Z_: I think what we're looking for is [the dialog element](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog)?
GiteaMirror added the kind/bugconfirmed labels 2025-11-01 20:56:23 -05:00
Author
Owner

@kolaente commented on GitHub (Jun 24, 2025):

This has been fixed recently. Please check with the next unstable build (should be ready for deployment in ~30min, also on try).

@kolaente commented on GitHub (Jun 24, 2025): This has been fixed recently. Please check with the next unstable build (should be ready for deployment in ~30min, also on [try](https://try.vikunja.io)).
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#452