[PR #904] [MERGED] feat: enable cors by default for desktop app #4512

Closed
opened 2026-04-16 13:06:07 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/904
Author: @kolaente
Created: 6/10/2025
Status: Merged
Merged: 6/10/2025
Merged by: @kolaente

Base: mainHead: codex/add-desktop-app-host-to-cors-headers


📝 Commits (2)

  • c670b18 Enable cors for desktop app by default
  • 90eae88 Include localhost in default CORS origins

📊 Changes

2 files changed (+8 additions, -5 deletions)

View changed files

📝 config-raw.json (+6 -3)
📝 pkg/config/config.go (+2 -2)

📄 Description

Summary

  • allow CORS by default
  • restrict default allowed origins to the desktop app on 127.0.0.1

Testing

  • go test ./... (fails: could not read fixture files)

https://chatgpt.com/codex/tasks/task_e_68480a3450ac8322aaeb98504f5d21b8


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/904 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 6/10/2025 **Status:** ✅ Merged **Merged:** 6/10/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `codex/add-desktop-app-host-to-cors-headers` --- ### 📝 Commits (2) - [`c670b18`](https://github.com/go-vikunja/vikunja/commit/c670b18a3d9376e696811e1aea10c6d9944ae779) Enable cors for desktop app by default - [`90eae88`](https://github.com/go-vikunja/vikunja/commit/90eae8804f2797f88ac154670bd95b3ed4a24454) Include localhost in default CORS origins ### 📊 Changes **2 files changed** (+8 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `config-raw.json` (+6 -3) 📝 `pkg/config/config.go` (+2 -2) </details> ### 📄 Description ## Summary - allow CORS by default - restrict default allowed origins to the desktop app on `127.0.0.1` ## Testing - `go test ./...` *(fails: could not read fixture files)* ------ https://chatgpt.com/codex/tasks/task_e_68480a3450ac8322aaeb98504f5d21b8 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:06:07 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#4512