github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-03-09 07:13:35 -05:00
Code Issues 219 Packages Projects Releases 2 Wiki Activity

'Task Detail' page tries to render non-existent tasks #436

New Issue
Closed
opened 2025-11-01 20:56:12 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2025-11-01 20:56:12 -05:00
Owner
Copy Link

Originally created by @vikunja-bot on GitHub (Apr 1, 2025).

Original issue by dpschen on 2023-03-30T12:22:12.000Z

Description

  1. Invent a large numeric id e.g. 63653
  2. Use that id to open a task detail page: https://try.vikunja.io/tasks/63653

Expected result

Actual result

See Screenshot below

Vikunja Frontend Version

0.20.5+115-739fe0caa1

Vikunja API Version

v0.20.4+40-5114f53307

Browser and version

Brave is up to date Version 1.49.132 Chromium: 111.0.5563.147 (Official Build) (x86_64)

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

image

Original issue on Gitea

@kolaente commented on 2023-05-30T17:37:35.000Z:

I had a stab at this and while it's quite easy to catch a 404 response from the api and replace the currently active view with a 404 that will reset the route to the base url again, which looks kind of confusing. The solution I could think of would be to compute the current view in the App.vue component and then store a flag in pina to show the 404 component when it is set. That sounds pretty hacky to me though, there's got to be another way?

@kolaente commented on 2023-05-30T17:38:50.000Z:

Here's what I tried so far:

diff --git a/src/views/tasks/TaskDetailView.vue b/src/views/tasks/TaskDetailView.vue
index e891869d..c775fd7a 100644
--- a/src/views/tasks/TaskDetailView.vue
+++ b/src/views/tasks/TaskDetailView.vue
@@ -587,6 +587,10 @@ watch(taskId, async (id) => {
                attachmentStore.set(task.attachments)
                taskColor.value = task.hexColor
                setActiveFields()
+       } catch(e) {
+               if (e.response.status === 404) {
+                       router.replace({name: 'not-found'})
+               }
        } finally {
                await nextTick()
                scrollToHeading()
Originally created by @vikunja-bot on GitHub (Apr 1, 2025). _Original issue by dpschen on 2023-03-30T12:22:12.000Z_ ### Description 1) Invent a large numeric id e.g. `63653` 2) Use that id to open a task detail page: https://try.vikunja.io/tasks/63653 ## Expected result - Either normal 'not found' page (like https://try.vikunja.io/this-page-doesn-exist) or - a 'task not found' page. ## Actual result See Screenshot below ### Vikunja Frontend Version 0.20.5+115-739fe0caa1 ### Vikunja API Version v0.20.4+40-5114f53307 ### Browser and version Brave is up to date Version 1.49.132 Chromium: 111.0.5563.147 (Official Build) (x86_64) ### Can you reproduce the bug on the Vikunja demo site? Yes ### Screenshots ![image](/attachments/cbb0551b-3943-4357-b73f-466d872cd721) [Original issue on Gitea](https://kolaente.dev/vikunja/vikunja/issues/2036) --- _**@kolaente** commented on 2023-05-30T17:37:35.000Z_: I had a stab at this and while it's quite easy to catch a 404 response from the api and replace the currently active view with a 404 that will reset the route to the base url again, which looks kind of confusing. The solution I could think of would be to compute the current view in the `App.vue` component and then store a flag in pina to show the 404 component when it is set. That sounds pretty hacky to me though, there's got to be another way? --- _**@kolaente** commented on 2023-05-30T17:38:50.000Z_: Here's what I tried so far: ```diff diff --git a/src/views/tasks/TaskDetailView.vue b/src/views/tasks/TaskDetailView.vue index e891869d..c775fd7a 100644 --- a/src/views/tasks/TaskDetailView.vue +++ b/src/views/tasks/TaskDetailView.vue @@ -587,6 +587,10 @@ watch(taskId, async (id) => { attachmentStore.set(task.attachments) taskColor.value = task.hexColor setActiveFields() + } catch(e) { + if (e.response.status === 404) { + router.replace({name: 'not-found'}) + } } finally { await nextTick() scrollToHeading()
GiteaMirror added the kind/bugconfirmed labels 2025-11-01 20:56:12 -05:00
GiteaMirror commented 2025-11-01 20:56:13 -05:00
Author
Owner
Copy Link

@kolaente commented on GitHub (Aug 3, 2025):

Not a problem anymore.

@kolaente commented on GitHub (Aug 3, 2025): Not a problem anymore.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/caldav
area/filters
area/frontend
area/gantt
area/internal-code
area/typesense
bug
changes requested
confirmed
dependencies
enhancement
good first issue
help wanted
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label confirmed kind/bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#436
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?