github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-07-16 06:42:23 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2435] [MERGED] fix(caldav): Replace href with pathname from parseURL for api base #4140

New Issue
Closed
opened 2026-03-22 15:04:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-22 15:04:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2435
Author: @mdrkrg
Created: 3/21/2026
Status: ✅ Merged
Merged: 3/22/2026
Merged by: @kolaente

Base: main ← Head: fix/caldav-api-base

📝 Commits (1)

  • f1b5cd8 fix(caldav): Replace href with pathname from parseURL for api base

📊 Changes

1 file changed (+6 additions, -5 deletions)

View changed files

📝 frontend/src/stores/config.ts (+6 -5)

📄 Description

Looking at the source code of ufo.parseURL:

export function parseURL(input = "", defaultProto?: string): ParsedURL {
  const _specialProtoMatch = input.match(
    /^[\s\0]*(blob:|data:|javascript:|vbscript:)(.*)/i,
  );
  if (_specialProtoMatch) {
    const [, _proto, _pathname = ""] = _specialProtoMatch;
    return {
      protocol: _proto.toLowerCase(),
      pathname: _pathname,
      href: _proto + _pathname,
      auth: "",
      host: "",
      search: "",
      hash: "",
    };
  }
  // ...

  return {
    protocol: protocol.toLowerCase(),
    auth: auth ? auth.slice(0, Math.max(0, auth.length - 1)) : "",
    host,
    pathname,
    search,
    hash,
    [protocolRelative]: !protocol,
  };
}

parseURL only return href for special protocols (blob, data, javascript, vbscript). For API_BASE, href will be undefined.

As a consequence, the computed apiBase will always be root path. For example: https://try.vikunja.io/. This is never a problem for standard deployments though, but when I'm trying to host it on some path prefix (e.g., /vikunja), the CalDAV URL would be wrong.

The patch usees pathname from ufo.parseURL which will not be undefined.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2435 **Author:** [@mdrkrg](https://github.com/mdrkrg) **Created:** 3/21/2026 **Status:** ✅ Merged **Merged:** 3/22/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix/caldav-api-base` --- ### 📝 Commits (1) - [`f1b5cd8`](https://github.com/go-vikunja/vikunja/commit/f1b5cd8082bc7e4b65c161f22ab390aa5ed879e7) fix(caldav): Replace href with pathname from parseURL for api base ### 📊 Changes **1 file changed** (+6 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/stores/config.ts` (+6 -5) </details> ### 📄 Description Looking at the source code of `ufo.parseURL`: ```ts export function parseURL(input = "", defaultProto?: string): ParsedURL { const _specialProtoMatch = input.match( /^[\s\0]*(blob:|data:|javascript:|vbscript:)(.*)/i, ); if (_specialProtoMatch) { const [, _proto, _pathname = ""] = _specialProtoMatch; return { protocol: _proto.toLowerCase(), pathname: _pathname, href: _proto + _pathname, auth: "", host: "", search: "", hash: "", }; } // ... return { protocol: protocol.toLowerCase(), auth: auth ? auth.slice(0, Math.max(0, auth.length - 1)) : "", host, pathname, search, hash, [protocolRelative]: !protocol, }; } ``` `parseURL` only return `href` for special protocols (blob, data, javascript, vbscript). For API_BASE, `href` will be undefined. As a consequence, the computed `apiBase` will always be root path. For example: `https://try.vikunja.io/`. This is never a problem for standard deployments though, but when I'm trying to host it on some path prefix (e.g., `/vikunja`), the CalDAV URL would be wrong. The patch usees `pathname` from `ufo.parseURL` which will not be undefined. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-22 15:04:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#4140
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?