github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-08 04:48:27 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2415] [MERGED] fix(tasks): support both expand and expand[] query parameter formats #4123

New Issue
Closed
opened 2026-03-22 15:04:02 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-22 15:04:02 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2415
Author: @tink-bot
Created: 3/19/2026
Status: ✅ Merged
Merged: 3/19/2026
Merged by: @kolaente

Base: main ← Head: fix/expand-query-param-format

📝 Commits (3)

  • a241cdc fix(tasks): support both expand and expand[] query parameter formats
  • fbadd7c fix(tasks): resolve appendAssign lint warnings
  • 1035c1d fix(tasks): simplify expand merge to satisfy appendAssign lint

📊 Changes

3 files changed (+15 additions, -6 deletions)

View changed files

📝 pkg/models/task_collection.go (+9 -3)
📝 pkg/models/tasks.go (+5 -3)
📝 pkg/models/tasks_permissions.go (+1 -0)

📄 Description

The expand query parameter only supported the expand[]=foo array format, but the swagger docs described it as a plain string parameter. This adds support for both formats (expand=foo and expand[]=foo), matching the existing pattern used by sort_by and order_by parameters.

Closes #2408

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2415 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 3/19/2026 **Status:** ✅ Merged **Merged:** 3/19/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix/expand-query-param-format` --- ### 📝 Commits (3) - [`a241cdc`](https://github.com/go-vikunja/vikunja/commit/a241cdce83c33117675b53ab88a22332663f8d02) fix(tasks): support both expand and expand[] query parameter formats - [`fbadd7c`](https://github.com/go-vikunja/vikunja/commit/fbadd7c0d6dd0e270b99584fa0a7c7c4dad11753) fix(tasks): resolve appendAssign lint warnings - [`1035c1d`](https://github.com/go-vikunja/vikunja/commit/1035c1d602ddb93c451e1e702ba18be52f2a5dd8) fix(tasks): simplify expand merge to satisfy appendAssign lint ### 📊 Changes **3 files changed** (+15 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `pkg/models/task_collection.go` (+9 -3) 📝 `pkg/models/tasks.go` (+5 -3) 📝 `pkg/models/tasks_permissions.go` (+1 -0) </details> ### 📄 Description The `expand` query parameter only supported the `expand[]=foo` array format, but the swagger docs described it as a plain string parameter. This adds support for both formats (`expand=foo` and `expand[]=foo`), matching the existing pattern used by `sort_by` and `order_by` parameters. Closes #2408 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-22 15:04:02 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#4123
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?