github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 11:37:49 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2345] [MERGED] fix: validate default settings timezone on startup #4077

New Issue
Closed
opened 2026-03-22 15:01:18 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-22 15:01:18 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2345
Author: @tink-bot
Created: 3/3/2026
Status: ✅ Merged
Merged: 3/3/2026
Merged by: @kolaente

Base: main ← Head: fix-default-timezone

📝 Commits (2)

  • bce4882 fix: validate default settings timezone and fall back to service timezone
  • 2710c12 fix: also fall back when default timezone is empty

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 pkg/config/config.go (+3 -1)

📄 Description

Summary

  • Replaces the empty-string check for DefaultSettingsTimezone with proper time.LoadLocation validation
  • If the configured timezone is invalid (including the placeholder <time zone set at service.timezone>), falls back to ServiceTimeZone
  • Follows the same validation approach used for ServiceTimeZone in pkg/initialize/init.go

Closes #962

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2345 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 3/3/2026 **Status:** ✅ Merged **Merged:** 3/3/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-default-timezone` --- ### 📝 Commits (2) - [`bce4882`](https://github.com/go-vikunja/vikunja/commit/bce48827e1191c7c57066eac9c313c6d41e95cae) fix: validate default settings timezone and fall back to service timezone - [`2710c12`](https://github.com/go-vikunja/vikunja/commit/2710c12f7b5f68b62d3392642a40ea9559264271) fix: also fall back when default timezone is empty ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/config/config.go` (+3 -1) </details> ### 📄 Description ## Summary - Replaces the empty-string check for `DefaultSettingsTimezone` with proper `time.LoadLocation` validation - If the configured timezone is invalid (including the placeholder `<time zone set at service.timezone>`), falls back to `ServiceTimeZone` - Follows the same validation approach used for `ServiceTimeZone` in `pkg/initialize/init.go` Closes #962 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-22 15:01:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#4077
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?