[PR #2299] [MERGED] refactor: remove typesense support #4049

Closed
opened 2026-03-22 14:59:55 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2299
Author: @kolaente
Created: 2/25/2026
Status: ✅ Merged
Merged: 2/25/2026
Merged by: @kolaente

Base: main ← Head: refactor-remove-typesense


📝 Commits (1)

  • c3ec183 refactor: remove typesense support

📊 Changes

18 files changed (+39 additions, -1255 deletions)

View changed files

📝 .golangci.yml (+0 -4)
📝 config-raw.json (+0 -20)
📝 go.mod (+0 -4)
📝 go.sum (+0 -12)
📝 pkg/cmd/doctor.go (+1 -1)
➖ pkg/cmd/index.go (+0 -73)
📝 pkg/config/config.go (+0 -7)
📝 pkg/doctor/services.go (+0 -68)
📝 pkg/initialize/init.go (+0 -3)
➕ pkg/migration/20260225114726.go (+35 -0)
📝 pkg/models/listeners.go (+0 -130)
📝 pkg/models/models.go (+0 -1)
📝 pkg/models/saved_filters.go (+2 -28)
📝 pkg/models/task_position.go (+0 -5)
📝 pkg/models/task_search.go (+0 -271)
📝 pkg/models/task_search_bench_test.go (+0 -13)
📝 pkg/models/tasks.go (+1 -18)
➖ pkg/models/typesense.go (+0 -597)

📄 Description

Summary

This PR fully removes the optional Typesense search backend from Vikunja. The database searcher remains the only search implementation.

Changes

Files Deleted

  • pkg/models/typesense.go - Core Typesense integration file
  • pkg/cmd/index.go - CLI command for Typesense indexing

Files Modified

  • Simplified task search to always use database searcher
  • Removed Typesense event listeners for task sync
  • Removed TypesenseSync model registration
  • Removed Typesense config keys and defaults
  • Removed Typesense doctor health check
  • Removed Typesense initialization from startup
  • Cleaned up benchmark test
  • Removed golangci-lint suppression for typesense.go
  • Removed typesense-go dependency

New Files

  • pkg/migration/20260225114726.go - Migration to drop the typesense_sync table

Testing

  • Build passes
  • Lint passes with 0 issues
  • Feature tests pass
  • Web tests pass

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2299 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 2/25/2026 **Status:** ✅ Merged **Merged:** 2/25/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `refactor-remove-typesense` --- ### 📝 Commits (1) - [`c3ec183`](https://github.com/go-vikunja/vikunja/commit/c3ec183f22d1fbfb04e2f2ea0856446f61f0a897) refactor: remove typesense support ### 📊 Changes **18 files changed** (+39 additions, -1255 deletions) <details> <summary>View changed files</summary> 📝 `.golangci.yml` (+0 -4) 📝 `config-raw.json` (+0 -20) 📝 `go.mod` (+0 -4) 📝 `go.sum` (+0 -12) 📝 `pkg/cmd/doctor.go` (+1 -1) ➖ `pkg/cmd/index.go` (+0 -73) 📝 `pkg/config/config.go` (+0 -7) 📝 `pkg/doctor/services.go` (+0 -68) 📝 `pkg/initialize/init.go` (+0 -3) ➕ `pkg/migration/20260225114726.go` (+35 -0) 📝 `pkg/models/listeners.go` (+0 -130) 📝 `pkg/models/models.go` (+0 -1) 📝 `pkg/models/saved_filters.go` (+2 -28) 📝 `pkg/models/task_position.go` (+0 -5) 📝 `pkg/models/task_search.go` (+0 -271) 📝 `pkg/models/task_search_bench_test.go` (+0 -13) 📝 `pkg/models/tasks.go` (+1 -18) ➖ `pkg/models/typesense.go` (+0 -597) </details> ### 📄 Description ## Summary This PR fully removes the optional Typesense search backend from Vikunja. The database searcher remains the only search implementation. ## Changes ### Files Deleted - pkg/models/typesense.go - Core Typesense integration file - pkg/cmd/index.go - CLI command for Typesense indexing ### Files Modified - Simplified task search to always use database searcher - Removed Typesense event listeners for task sync - Removed TypesenseSync model registration - Removed Typesense config keys and defaults - Removed Typesense doctor health check - Removed Typesense initialization from startup - Cleaned up benchmark test - Removed golangci-lint suppression for typesense.go - Removed typesense-go dependency ### New Files - pkg/migration/20260225114726.go - Migration to drop the typesense_sync table ## Testing - Build passes - Lint passes with 0 issues - Feature tests pass - Web tests pass --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-22 14:59:55 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#4049