github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-07 20:38:46 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2287] [MERGED] fix: prevent cursor reset when typing in filter input #4037

New Issue
Closed
opened 2026-03-22 14:59:17 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-22 14:59:17 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2287
Author: @kolaente
Created: 2/24/2026
Status: ✅ Merged
Merged: 2/24/2026
Merged by: @kolaente

Base: main ← Head: fix-filter-input-cursor-reset

📝 Commits (3)

  • eee9202 test: add filter whitespace normalization tests
  • 5c13d86 fix: prevent cursor reset when typing in filter input
  • 35b59e1 fix: reset emission guard after applying external model updates

📊 Changes

2 files changed (+50 additions, -5 deletions)

View changed files

📝 frontend/src/components/input/filter/FilterInput.vue (+20 -5)
📝 frontend/src/helpers/filters.test.ts (+30 -0)

📄 Description

Summary

  • Track the last value emitted by the editor's onUpdate handler in FilterInput.vue. When the modelValue watch fires with a value matching the last emission, skip the setEditorContentFromModelValue call to avoid a destructive round-trip where transformFilterStringForApi normalizes whitespace (e.g., labels=f → labels = f), causing setContent to replace the editor text and reset the cursor position.
  • Add regression tests documenting that transformFilterStringForApi normalizes spacing around operators.

Test plan

  • Type labels= followed by a search term — cursor stays at end, does not jump back
  • Type labels = (with spaces) followed by a search term — cursor stays at end
  • Type compound filters like done = false && labels = then a label name — cursor does not jump
  • Click a date value to open date picker — date picker still works correctly
  • Load an existing saved filter (e.g., labels = 42) — editor shows human-readable version
  • Unit tests pass: cd frontend && pnpm test:unit src/helpers/filters.test.ts

Fixes #2268

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2287 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 2/24/2026 **Status:** ✅ Merged **Merged:** 2/24/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-filter-input-cursor-reset` --- ### 📝 Commits (3) - [`eee9202`](https://github.com/go-vikunja/vikunja/commit/eee92026cced99b14e01c93fdd70aee762353147) test: add filter whitespace normalization tests - [`5c13d86`](https://github.com/go-vikunja/vikunja/commit/5c13d86b945abd347e6aa2dd0df862143e61db47) fix: prevent cursor reset when typing in filter input - [`35b59e1`](https://github.com/go-vikunja/vikunja/commit/35b59e12a273c2e39d69acb7ea7bccd4396ed792) fix: reset emission guard after applying external model updates ### 📊 Changes **2 files changed** (+50 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/input/filter/FilterInput.vue` (+20 -5) 📝 `frontend/src/helpers/filters.test.ts` (+30 -0) </details> ### 📄 Description ## Summary - Track the last value emitted by the editor's `onUpdate` handler in `FilterInput.vue`. When the `modelValue` watch fires with a value matching the last emission, skip the `setEditorContentFromModelValue` call to avoid a destructive round-trip where `transformFilterStringForApi` normalizes whitespace (e.g., `labels=f` → `labels = f`), causing `setContent` to replace the editor text and reset the cursor position. - Add regression tests documenting that `transformFilterStringForApi` normalizes spacing around operators. ## Test plan - [ ] Type `labels=` followed by a search term — cursor stays at end, does not jump back - [ ] Type `labels = ` (with spaces) followed by a search term — cursor stays at end - [ ] Type compound filters like `done = false && labels = ` then a label name — cursor does not jump - [ ] Click a date value to open date picker — date picker still works correctly - [ ] Load an existing saved filter (e.g., `labels = 42`) — editor shows human-readable version - [ ] Unit tests pass: `cd frontend && pnpm test:unit src/helpers/filters.test.ts` Fixes #2268 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-22 14:59:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#4037
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?