mirror of
https://github.com/go-vikunja/vikunja.git
synced 2026-03-09 07:13:35 -05:00
Separate dialogs from popovers #396
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/vikunja#396
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @vikunja-bot on GitHub (Apr 1, 2025).
Original issue by dpschen on 2021-11-08T14:59:27.000Z
We should separate these usecase:
popover (former modal; popover is the better naming, also allows better distinction from 'model') is used for pages, basically an overlay with a UIs.
popovers usually have a url
dialog: asking the user a question. e.g. delete.
Not sure what to do with modals that had an url but would then loose it. But this also isn't consequent right now: some delete modals have a url others don't.
Popovers should not be stacked (although we might have some exceptions).
Dialogs might be stacked, but this is also discouraged. Better would be to create a user flow where this is not needed.
See also:
https://kolaente.dev/vikunja/frontend/pulls/816#issuecomment-16745
Original issue on Gitea
@kolaente commented on 2021-11-09T22:50:29.000Z:
I like the idea.
That sounds like it should be more consistent.
Did you check which modals have a url and which don't? My guess is all modals which are accessible from the menu directly have one while the ones from a detail page don't.
dpschen commented on 2021-11-11T01:45:24.000Z:
I didn't check, but that might be!
Either way still not sure which way to go here: I like that there is a direct url for e.g. editing stuff. For deleting it doesn't make so much sense, since you shouldn't be able to navigate back to a delete dialog after you pressed delete.
dpschen commented on 2021-11-19T17:23:15.000Z:
Because of https://kolaente.dev/vikunja/frontend/issues/1037
I started implementing dialogs based on https://headlessui.dev/vue/dialog but with a promise interface.
Still iterating on that idea.
@konrad: what do you think in general?
@kolaente commented on 2021-11-22T18:35:53.000Z:
If I understood the docs from headless ui correctly, using their dialog component would add the focus trap (that's currently not working)?
In general, I think we could move forward with it.
dpschen commented on 2021-11-22T20:06:56.000Z:
Yes they implement a lot of heavy to implement accessability stuff in there.
dpschen commented on 2021-11-22T20:07:26.000Z:
I started with this already, but still in an early phase.
dpschen commented on 2021-11-27T13:21:09.000Z:
I realized that the dialogs should probably be implemented in a way that you cann them via a function that returns a promise.
Does that make sense?
dpschen commented on 2022-05-20T16:35:03.000Z:
To remember for later: https://github.com/rlemaigre/vue3-promise-dialog