github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-07-31 10:47:57 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2078] [MERGED] feat(frontend): add danger prop to XButton component #3916

New Issue
Closed
opened 2026-03-22 14:56:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-22 14:56:53 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2078
Author: @kolaente
Created: 1/10/2026
Status: ✅ Merged
Merged: 1/10/2026
Merged by: @kolaente

Base: main ← Head: feat-add-danger-prop-to-xbutton

📝 Commits (1)

  • 5f41a62 feat(frontend): add danger prop to XButton component

📊 Changes

8 files changed (+70 additions, -9 deletions)

View changed files

📝 frontend/src/components/input/Button.vue (+61 -0)
📝 frontend/src/components/sharing/LinkSharing.vue (+1 -1)
📝 frontend/src/components/sharing/UserTeam.vue (+1 -1)
📝 frontend/src/views/labels/ListLabels.vue (+1 -1)
📝 frontend/src/views/project/settings/ProjectSettingsBackground.vue (+1 -1)
📝 frontend/src/views/project/settings/ProjectSettingsWebhooks.vue (+1 -1)
📝 frontend/src/views/teams/EditTeam.vue (+2 -2)
📝 frontend/src/views/user/settings/TOTP.vue (+2 -2)

📄 Description

Summary

  • Added danger boolean prop to XButton component that applies danger styling (red background)
  • Added CSS styles for .is-danger that work with all button variants (primary, secondary, tertiary)
  • Updated 9 usages across the codebase to use the new danger prop instead of class="is-danger"

Test Plan

  • All 721 unit tests pass
  • ESLint passes
  • Manual verification: Labels edit view - delete button should be red
  • Manual verification: Teams edit view - delete team and remove member buttons should be red
  • Manual verification: Project webhooks settings - delete webhook button should be red
  • Manual verification: Project background settings - remove background button should be red text (tertiary variant)
  • Manual verification: TOTP settings - disable buttons should be red
  • Manual verification: Link sharing - delete link button should be red
  • Manual verification: User/Team sharing - remove button should be red

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2078 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 1/10/2026 **Status:** ✅ Merged **Merged:** 1/10/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `feat-add-danger-prop-to-xbutton` --- ### 📝 Commits (1) - [`5f41a62`](https://github.com/go-vikunja/vikunja/commit/5f41a62cfefdea0a4888351bd42f81ac3e9be037) feat(frontend): add danger prop to XButton component ### 📊 Changes **8 files changed** (+70 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/input/Button.vue` (+61 -0) 📝 `frontend/src/components/sharing/LinkSharing.vue` (+1 -1) 📝 `frontend/src/components/sharing/UserTeam.vue` (+1 -1) 📝 `frontend/src/views/labels/ListLabels.vue` (+1 -1) 📝 `frontend/src/views/project/settings/ProjectSettingsBackground.vue` (+1 -1) 📝 `frontend/src/views/project/settings/ProjectSettingsWebhooks.vue` (+1 -1) 📝 `frontend/src/views/teams/EditTeam.vue` (+2 -2) 📝 `frontend/src/views/user/settings/TOTP.vue` (+2 -2) </details> ### 📄 Description ## Summary - Added `danger` boolean prop to XButton component that applies danger styling (red background) - Added CSS styles for `.is-danger` that work with all button variants (primary, secondary, tertiary) - Updated 9 usages across the codebase to use the new `danger` prop instead of `class="is-danger"` ## Test Plan - [x] All 721 unit tests pass - [x] ESLint passes - [x] Manual verification: Labels edit view - delete button should be red - [x] Manual verification: Teams edit view - delete team and remove member buttons should be red - [x] Manual verification: Project webhooks settings - delete webhook button should be red - [x] Manual verification: Project background settings - remove background button should be red text (tertiary variant) - [x] Manual verification: TOTP settings - disable buttons should be red - [x] Manual verification: Link sharing - delete link button should be red - [x] Manual verification: User/Team sharing - remove button should be red --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-22 14:56:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#3916