[PR #1997] [MERGED] fix(editor): prevent TypeError when typing mentions in comments #3856

New Issue

GiteaMirror · 2026-03-22T14:55:40-05:00

GiteaMirror commented

2026-03-22 14:55:40 -05:00

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1997
Author: @kolaente
Created: 12/16/2025
Status: ✅ Merged
Merged: 12/16/2025
Merged by: @kolaente

Base: main ← Head: fix-mention-comment-error

📝 Commits (1)

39bb5a4 fix(editor): prevent TypeError when typing mentions in comments

📊 Changes

2 files changed (+81 additions, -2 deletions)

View changed files

📝 frontend/src/components/input/editor/mention/mentionSuggestion.ts (+2 -2)
➕ frontend/tests/e2e/task/mention-in-comment.spec.ts (+79 -0)

📄 Description

Summary

Fix TypeError when typing @ mentions in task comments
Add null checks for component variable in mentionSuggestion.ts to handle race conditions where onUpdate or onKeyDown fire before onStart completes

Test plan

Type @username in a task comment - no errors should appear
Playwright tests pass for mention functionality
Linting passes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1997 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 12/16/2025 **Status:** ✅ Merged **Merged:** 12/16/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-mention-comment-error` --- ### 📝 Commits (1) - [`39bb5a4`](https://github.com/go-vikunja/vikunja/commit/39bb5a4d851c4e5d24a24d669c25cd0435c4dcb1) fix(editor): prevent TypeError when typing mentions in comments ### 📊 Changes **2 files changed** (+81 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/input/editor/mention/mentionSuggestion.ts` (+2 -2) ➕ `frontend/tests/e2e/task/mention-in-comment.spec.ts` (+79 -0) </details> ### 📄 Description ## Summary - Fix TypeError when typing `@` mentions in task comments - Add null checks for `component` variable in `mentionSuggestion.ts` to handle race conditions where `onUpdate` or `onKeyDown` fire before `onStart` completes ## Test plan - [x] Type `@username` in a task comment - no errors should appear - [x] Playwright tests pass for mention functionality - [x] Linting passes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-03-22 14:55:40 -05:00

GiteaMirror closed this issue

2026-03-22 14:55:40 -05:00

Sign in to join this conversation.

Branches Tags

main

renovate/dev-dependencies

claude/analyze-beans-project-9VxoS

feat-huma-api-v2-migration

feat-v2-foundation

spike-huma-openapi3

claude/investigate-swagger3-support-nyyUa

feat-list-view-buckets

ci-mysql-8-test

codex/analyze-codebase-for-email-task-feature

feat-project-templates

csv-import-feature

claude/email-reply-comments-wpdcQ

fix-oidc-pkce-support

fix/overview-subtasks-expand

feat/bucket-select-task-detail

feat-soft-delete-projects

claude/review-bot-design-plan-cf5C3

claude/project-scoped-api-tokens-KTqR3

claude/explore-openclaw-integration-KQEzg

claude/project-scoped-api-tokens-yv5KS

fix-duplicate-close-button

feat-list-view-sorting

feat/official-vite-sentry-plugin

feat/highlight-overdue-tasks

feat/add-enter-key-form-submission-handling

feat/TipTap-nits

feat/update-caldavtimetotimestamp-parsing

feat-phosphor-icons

wip-plans

claude/investigate-issue-2173-llKme

fix-description-text-drag

feat-custom-keyboard-shortcuts

pr-1845-ci

codex/fix-drag-and-drop-behavior-inconsistency

copilot/add-clickable-labels-for-filtering

copilot/fix-issue-1786

playwright-migration

fix-kanban-repeating-wip

copilot/fix-1498

feature/replace-axios

codex/upgrade-to-tailwind-4.1.8-using-pnpm

codex/add-cypress-test-for-avatar-types

feature/biome

feature/oxc

codex/update-flexsearch-to-0.8.205

4r6ni9-codex/fix-deprecated-sass-@import-usage

codex/fix-deprecated-sass-@import-usage

codex/add-cypress-test-for-task-list-refresh-fix

codex/fix-quick-add-magic-not-adding-tasks

codex/fix-all-type-errors

codex/fix-mimetype-for-docs.json

feature/caldav-from-scratch

feature/gh-actions-hetzner

fix-ci

feat/new-logger

jyte-better-dev-config

feat/add-team-member-with-enter

fix/button-and-icon-types

fix/notifications-component-name-collision

feature/null-time

renovate/tailwindcss-4.x

feature/unplugin-vue-router

fix/deprecated-import

feature/zod-schema

renovate/golangci-golangci-lint-1.x

fix/tiptap-editor-reactive-destructuring

release/0.24

feat/improve-add-task

fix/saved-filter-search

feat/webp-and-avif-attachment-previews

feature/migrate-back-to-bulma

fix/sass-add-missing-list-import

feature/sticky-demo-bar

fix/gantt-view-switch

feature/typesense-position-join

feature/focus-visible

dependencies/golangci-lint

feature/better-filter-syntax

fix/tiptap-task-list

renovate/github.com-golang-jwt-jwt-v4-5.x

feature/hide-forbidden-related-tasks

renovate/golang-1.x

release/0.20

release/0.17

release/0.16

release/0.15

release/0.14

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vikunja#3856