github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-08 21:08:04 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #1994] [MERGED] fix(files): upload should work with vhost style #3853

New Issue
Closed
opened 2026-03-22 14:55:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-22 14:55:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1994
Author: @kolaente
Created: 12/16/2025
Status: ✅ Merged
Merged: 12/16/2025
Merged by: @kolaente

Base: main ← Head: fix-s3-upload-content-len

📝 Commits (4)

📊 Changes

4 files changed (+299 additions, -4 deletions)

View changed files

📝 pkg/config/config.go (+2 -0)
📝 pkg/files/filehandling.go (+15 -2)
📝 pkg/files/files.go (+130 -2)
📝 pkg/files/s3_test.go (+152 -0)

📄 Description

resolves https://github.com/go-vikunja/vikunja/issues/1905

Summary by CodeRabbit

  • New Features

    • S3 file uploads now include explicit content-length handling for improved reliability.
    • Automatic buffering support for non-seekable readers during S3 uploads.
    • Enhanced error reporting for S3 upload failures.

  • Chores

    • Added configuration option to specify a custom S3 temporary directory.

✏️ Tip: You can customize this high-level summary in your review settings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1994 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 12/16/2025 **Status:** ✅ Merged **Merged:** 12/16/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-s3-upload-content-len` --- ### 📝 Commits (4) - [`a223c7e`](https://github.com/go-vikunja/vikunja/commit/a223c7e7b5bb5e6d019aac0de6655388bca50c9b) fix(files): upload should work with vhost style - [`1b9cf6e`](https://github.com/go-vikunja/vikunja/commit/1b9cf6e045f57fece193e8dfc45de81b4c7179aa) fix lint - [`bcc807b`](https://github.com/go-vikunja/vikunja/commit/bcc807b99ed7b65b68cd78f1a74417390f1767e5) fix stuff - [`5f434ea`](https://github.com/go-vikunja/vikunja/commit/5f434eaad0a1f51c1d015467d5ce257271a2e8f7) cleanupx ### 📊 Changes **4 files changed** (+299 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `pkg/config/config.go` (+2 -0) 📝 `pkg/files/filehandling.go` (+15 -2) 📝 `pkg/files/files.go` (+130 -2) 📝 `pkg/files/s3_test.go` (+152 -0) </details> ### 📄 Description resolves https://github.com/go-vikunja/vikunja/issues/1905 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * S3 file uploads now include explicit content-length handling for improved reliability. * Automatic buffering support for non-seekable readers during S3 uploads. * Enhanced error reporting for S3 upload failures. * **Chores** * Added configuration option to specify a custom S3 temporary directory. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-22 14:55:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#3853
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?