github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-07-24 08:48:48 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

Read-only users can't comment #356

New Issue
Open
opened 2025-11-01 20:54:52 -05:00 by GiteaMirror · 3 comments
GiteaMirror commented 2025-11-01 20:54:52 -05:00
Owner
Copy Link
Copy Source

Originally created by @morrolinux on GitHub (Feb 18, 2025).

Description

As of now, users belonging to a group that has "Read Only" permissions over a project can only view the project and its tasks as expected.

The problem lies in the comments section of a task:
As a standard (RW) user, I can comment a task and tag a RO user, but he/she won't be able to reply to the comment, because the current policy is not to allow Read Only users to leave comments on tasks.

That, I think, would be a bit too restrictive for for any sorts of useful collaboration, as it makes no difference to the "sharing link" with read only setting.

Read only users should be able to at least comment on tasks, or maybe a more fine-grained permission system should be possible from the UI, since for the API keys it's already possible to have fine-grained permission control

Vikunja Version

5cea469

Browser and version

No response

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

No response

Originally created by @morrolinux on GitHub (Feb 18, 2025). ### Description As of now, users belonging to a group that has "Read Only" permissions over a project can only view the project and its tasks as expected. The problem lies in the comments section of a task: As a standard (RW) user, I can comment a task and tag a RO user, but he/she won't be able to reply to the comment, because the current policy is not to allow Read Only users to leave comments on tasks. That, I think, would be a bit too restrictive for for any sorts of useful collaboration, as it makes no difference to the "sharing link" with read only setting. Read only users should be able to at least comment on tasks, or maybe a more fine-grained permission system should be possible from the UI, since for the API keys it's already possible to have fine-grained permission control ### Vikunja Version 5cea469 ### Browser and version _No response_ ### Can you reproduce the bug on the Vikunja demo site? Yes ### Screenshots _No response_
GiteaMirror commented 2025-11-01 20:54:53 -05:00
Author
Owner
Copy Link
Copy Source

@kolaente commented on GitHub (Mar 1, 2025):

I'm pretty sure we could integrate that. Logically, this kind of makes sense because adding a comment is a write operation - but I understand why it does not make sense from a workflow perspective.

I've seen your video, would you be open to submitting your changes as a PR? I've commented about the other things as well, but the comment seems to be stuck in some kind of spam-review queue.

@kolaente commented on GitHub (Mar 1, 2025): I'm pretty sure we could integrate that. Logically, this kind of makes sense because adding a comment is a write operation - but I understand why it does not make sense from a workflow perspective. I've seen your video, would you be open to submitting your changes as a PR? I've commented about the other things as well, but the comment seems to be stuck in some kind of spam-review queue.
GiteaMirror commented 2025-11-01 20:54:53 -05:00
Author
Owner
Copy Link
Copy Source

@morrolinux commented on GitHub (Mar 1, 2025):

Hi @kolaente
thanks for getting back to me!

Unfortunately I wasn't able to retrieve your comment even in my youtube spam section: it's just... gone!
I'd love to know what your other comments were and possibly discuss them, just let me know if/where you'd be reachable :)

Now for the feature:
I actually wanted to make a PR, but after creating an account on gitea I got an error:

Your account is prohibited from signing in, please contact your site administrator.

And I haven't received any confirmation email to click on or stuff like that.
Maybe I've missed something?

Best,
Moreno

@morrolinux commented on GitHub (Mar 1, 2025): Hi @kolaente thanks for getting back to me! Unfortunately I wasn't able to retrieve your comment even in my youtube spam section: it's just... gone! I'd love to know what your other comments were and possibly discuss them, just let me know if/where you'd be reachable :) Now for the feature: I actually wanted to make a PR, but after creating an account on gitea I got an error: > Your account is prohibited from signing in, please contact your site administrator. And I haven't received any confirmation email to click on or stuff like that. Maybe I've missed something? Best, Moreno
GiteaMirror commented 2025-11-01 20:54:53 -05:00
Author
Owner
Copy Link
Copy Source

@kolaente commented on GitHub (Mar 1, 2025):

Hey Moreno!

Unfortunately I wasn't able to retrieve your comment even in my youtube spam section: it's just... gone!

Very interesting. I wasn't able to find it either.

From memory: I'm certain we could integrate the gantt changes, but we'd need to make a plan and look a little more into them. I think the easiest way going forward would be if you open issues here or threads in the forum to discuss these further. If it helped you more, we could also hop on a call to discuss this.

And I haven't received any confirmation email to click on or stuff like that.
Maybe I've missed something?

I've just enabled your account - unfortunately, each account needs to be enabled manually to prevent spam.

@kolaente commented on GitHub (Mar 1, 2025): Hey Moreno! > Unfortunately I wasn't able to retrieve your comment even in my youtube spam section: it's just... gone! Very interesting. I wasn't able to find it either. From memory: I'm certain we could integrate the gantt changes, but we'd need to make a plan and look a little more into them. I think the easiest way going forward would be if you open issues here or [threads in the forum](https://community.vikunja.io) to discuss these further. If it helped you more, we could also hop on a call to discuss this. > And I haven't received any confirmation email to click on or stuff like that. Maybe I've missed something? I've just enabled your account - unfortunately, each account needs to be enabled manually to prevent spam.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#356