github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 03:27:53 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #1398] feat: add independent tasks due today reminders #3393

New Issue
Open
opened 2026-03-22 14:42:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-22 14:42:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1398
Author: @kolaente
Created: 9/3/2025
Status: 🔄 Open

Base: main ← Head: codex/analyze-codebase-for-email-task-feature

📝 Commits (5)

  • 1d7d823 fix: address review feedback for today reminders
  • 6f819c1 refactor: rename overdue reminders time field
  • 42d8c17 fix: add missing reminder translations
  • 6797301 fix tests
  • f6f5c1f fix: resolve auto-merge issues from rebase

📊 Changes

28 files changed (+857 additions, -233 deletions)

View changed files

➕ PLAN.md (+66 -0)
📝 config-raw.json (+7 -2)
➕ config.yml.sample (+459 -0)
📝 frontend/src/i18n/lang/en.json (+2 -1)
📝 frontend/src/modelTypes/IUserSettings.ts (+4 -3)
📝 frontend/src/models/userSettings.ts (+2 -1)
📝 frontend/src/views/user/settings/General.vue (+24 -16)
📝 frontend/tests/e2e/task/overview.spec.ts (+1 -1)
📝 pkg/config/config.go (+3 -2)
📝 pkg/db/fixtures/task_reminders.yml (+0 -11)
📝 pkg/db/fixtures/tasks.yml (+5 -2)
📝 pkg/db/fixtures/users.yml (+1 -0)
📝 pkg/i18n/lang/en.json (+4 -1)
➕ pkg/migration/20250903072808.go (+40 -0)
➕ pkg/migration/20250903072809.go (+45 -0)
📝 pkg/models/label_task_test.go (+1 -1)
📝 pkg/models/label_test.go (+6 -4)
📝 pkg/models/notifications.go (+48 -59)
📝 pkg/models/project_users_test.go (+3 -2)
📝 pkg/models/task_collection_test.go (+21 -43)

...and 8 more files

📄 Description

Summary

  • rename overdue reminder implementation to task_today_reminder and keep userWithTasks structure for overdue and due-today tasks
  • add test fixture task #47 after task #46 and remove redundant config default
  • drop unused Cypress test for today reminders

Testing

  • mage lint:fix (fails: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0))
  • mage test:feature (fails: go: no such tool "covdata" )
  • pnpm lint:fix
  • pnpm lint:styles:fix

https://chatgpt.com/codex/tasks/task_e_68b75b6d6c508322b23c24e9f3e6e26d

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1398 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 9/3/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `codex/analyze-codebase-for-email-task-feature` --- ### 📝 Commits (5) - [`1d7d823`](https://github.com/go-vikunja/vikunja/commit/1d7d8239ba193977aa6422253f9391cfc4b0fb5e) fix: address review feedback for today reminders - [`6f819c1`](https://github.com/go-vikunja/vikunja/commit/6f819c17543aa8b7d5d170ab16f10e7ae0ed6414) refactor: rename overdue reminders time field - [`42d8c17`](https://github.com/go-vikunja/vikunja/commit/42d8c1755175763a9a86577db83662cb2f2945f7) fix: add missing reminder translations - [`6797301`](https://github.com/go-vikunja/vikunja/commit/679730107599a2def289df917048cb03b99ec1da) fix tests - [`f6f5c1f`](https://github.com/go-vikunja/vikunja/commit/f6f5c1f94d864fd2ae090eb0a63a8cccad874545) fix: resolve auto-merge issues from rebase ### 📊 Changes **28 files changed** (+857 additions, -233 deletions) <details> <summary>View changed files</summary> ➕ `PLAN.md` (+66 -0) 📝 `config-raw.json` (+7 -2) ➕ `config.yml.sample` (+459 -0) 📝 `frontend/src/i18n/lang/en.json` (+2 -1) 📝 `frontend/src/modelTypes/IUserSettings.ts` (+4 -3) 📝 `frontend/src/models/userSettings.ts` (+2 -1) 📝 `frontend/src/views/user/settings/General.vue` (+24 -16) 📝 `frontend/tests/e2e/task/overview.spec.ts` (+1 -1) 📝 `pkg/config/config.go` (+3 -2) 📝 `pkg/db/fixtures/task_reminders.yml` (+0 -11) 📝 `pkg/db/fixtures/tasks.yml` (+5 -2) 📝 `pkg/db/fixtures/users.yml` (+1 -0) 📝 `pkg/i18n/lang/en.json` (+4 -1) ➕ `pkg/migration/20250903072808.go` (+40 -0) ➕ `pkg/migration/20250903072809.go` (+45 -0) 📝 `pkg/models/label_task_test.go` (+1 -1) 📝 `pkg/models/label_test.go` (+6 -4) 📝 `pkg/models/notifications.go` (+48 -59) 📝 `pkg/models/project_users_test.go` (+3 -2) 📝 `pkg/models/task_collection_test.go` (+21 -43) _...and 8 more files_ </details> ### 📄 Description ## Summary - rename overdue reminder implementation to task_today_reminder and keep userWithTasks structure for overdue and due-today tasks - add test fixture task #47 after task #46 and remove redundant config default - drop unused Cypress test for today reminders ## Testing - `mage lint:fix` *(fails: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0))* - `mage test:feature` *(fails: go: no such tool "covdata" )* - `pnpm lint:fix` - `pnpm lint:styles:fix` ------ https://chatgpt.com/codex/tasks/task_e_68b75b6d6c508322b23c24e9f3e6e26d --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-22 14:42:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#3393
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?