github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-03-25 16:01:22 -05:00
Code Issues 447 Packages Projects Releases 9 Wiki Activity

[PR #1011] [MERGED] Fix ambiguous done column in task sorting #3072

New Issue
Closed
opened 2026-03-22 14:30:17 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-22 14:30:17 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1011
Author: @kolaente
Created: 6/24/2025
Status: ✅ Merged
Merged: 6/24/2025
Merged by: @kolaente

Base: main ← Head: codex/fix-bug-in-vikunja-issue-1009

📝 Commits (1)

  • 7f94543 fix: prefix task fields in sorting

📊 Changes

1 file changed (+5 additions, -4 deletions)

View changed files

📝 pkg/models/task_search.go (+5 -4)

📄 Description

Resolves https://github.com/go-vikunja/vikunja/issues/1009

Summary

  • prefix all task fields with the tasks table when constructing SQL ORDER BY clauses
  • ensure bucket sorting uses the proper table alias

Testing

  • mage lint:fix
  • mage test:feature

https://chatgpt.com/codex/tasks/task_e_685aff1610cc83228e66a9646309697d

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1011 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 6/24/2025 **Status:** ✅ Merged **Merged:** 6/24/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `codex/fix-bug-in-vikunja-issue-1009` --- ### 📝 Commits (1) - [`7f94543`](https://github.com/go-vikunja/vikunja/commit/7f94543b194934e3093563c05a1ab8cb56097256) fix: prefix task fields in sorting ### 📊 Changes **1 file changed** (+5 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `pkg/models/task_search.go` (+5 -4) </details> ### 📄 Description Resolves https://github.com/go-vikunja/vikunja/issues/1009 ## Summary - prefix all task fields with the tasks table when constructing SQL ORDER BY clauses - ensure bucket sorting uses the proper table alias ## Testing - `mage lint:fix` - `mage test:feature` ------ https://chatgpt.com/codex/tasks/task_e_685aff1610cc83228e66a9646309697d --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-22 14:30:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/caldav
area/filters
area/frontend
area/gantt
area/internal-code
area/typesense
bug
changes requested
confirmed
dependencies
enhancement
good first issue
help wanted
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#3072
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?