Wrong color of Card tittle when switching to Dark mode #1894

Closed
opened 2026-03-22 13:44:34 -05:00 by GiteaMirror · 14 comments
Owner

Originally created by @hugosxm on GitHub (Dec 11, 2023).

Description

Hi,

I just tried to color cards, and I found that when you switch theme from light to dark, it reverts color of the colored card, but this is not good, if you choose a yellow or white color you won't be able to read the tittle anymore :

Dark mode :

vikunja_dark

Light mode :
vikunja_light

Dark mode should revert color of the tittle only for cards that are close to black and white I think.

Sorry if this is not clear ^^

Vikunja Frontend Version

0.21.0

Vikunja API Version

0.21.0

Browser and version

No response

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

No response

Originally created by @hugosxm on GitHub (Dec 11, 2023). ### Description Hi, I just tried to color cards, and I found that when you switch theme from light to dark, it reverts color of the colored card, but this is not good, if you choose a yellow or white color you won't be able to read the tittle anymore : Dark mode : ![vikunja_dark](https://github.com/go-vikunja/frontend/assets/23743455/d9f67dda-1450-4334-9bd7-79d20d1e44a8) Light mode : ![vikunja_light](https://github.com/go-vikunja/frontend/assets/23743455/a5f752ef-6a4b-44a5-8dd4-9d700500c4ad) Dark mode should revert color of the tittle only for cards that are close to black and white I think. Sorry if this is not clear ^^ ### Vikunja Frontend Version 0.21.0 ### Vikunja API Version 0.21.0 ### Browser and version _No response_ ### Can you reproduce the bug on the Vikunja demo site? Yes ### Screenshots _No response_
Author
Owner

@kolaente commented on GitHub (Dec 13, 2023):

Fixed in 34e4862c88. Please check with the next unstable build.

@kolaente commented on GitHub (Dec 13, 2023): Fixed in 34e4862c88904f114a36e65c851361b11443fadd. Please check with the next unstable build.
Author
Owner

@hugosxm commented on GitHub (Dec 13, 2023):

@kolaente Yep ! Much better ! Thanks for the very quick fix !!

@hugosxm commented on GitHub (Dec 13, 2023): @kolaente Yep ! Much better ! Thanks for the very quick fix !!
Author
Owner

@hugosxm commented on GitHub (Jan 19, 2024):

@kolaente sorry but i just saw this :

vikunja_card_color

Maybe we should fix all the text of the card and not just the tittle ...

@hugosxm commented on GitHub (Jan 19, 2024): @kolaente sorry but i just saw this : ![vikunja_card_color](https://github.com/go-vikunja/frontend/assets/23743455/02f92c68-c6b9-4032-8d75-9739a378d304) Maybe we should fix all the text of the card and not just the tittle ...
Author
Owner

@kolaente commented on GitHub (Jan 20, 2024):

Pushed another fix in da311fce9e - please check again with the next unstable build.

@kolaente commented on GitHub (Jan 20, 2024): Pushed another fix in da311fce9ebe3261b74b2f159e01d00a1284133e - please check again with the next unstable build.
Author
Owner

@hugosxm commented on GitHub (Jan 21, 2024):

Seems the same to me, i used sha256:300eb43e01de4cec355bd197d2d62f8a872b55a088ee178a6a53cd2a757edf67 image, pushed two hours ago ? Am I on the right image to test ?

@hugosxm commented on GitHub (Jan 21, 2024): Seems the same to me, i used sha256:300eb43e01de4cec355bd197d2d62f8a872b55a088ee178a6a53cd2a757edf67 image, pushed two hours ago ? Am I on the right image to test ?
Author
Owner

@kolaente commented on GitHub (Jan 21, 2024):

@hugosxm which Vikunja version is that?

@kolaente commented on GitHub (Jan 21, 2024): @hugosxm which Vikunja version is that?
Author
Owner

@hugosxm commented on GitHub (Jan 21, 2024):

@kolaente from the webui : Version : 0.22.0+68-c7b70844c6

@hugosxm commented on GitHub (Jan 21, 2024): @kolaente from the webui : Version : 0.22.0+68-c7b70844c6
Author
Owner

@kolaente commented on GitHub (Jan 22, 2024):

Seems to work fine for me. Can you share a screenshot and explain what you think is wrong?

@kolaente commented on GitHub (Jan 22, 2024): Seems to work fine for me. Can you share a screenshot and explain what you think is wrong?
Author
Owner

@hugosxm commented on GitHub (Jan 22, 2024):

I have exaclty the same behavior, like my screenshot 3 days ago, I tried to clean the cache, different browser... weird

EDIT : On the red card the number is colored right, but not the task progression :

vikunja_card_color2

@kolaente

@hugosxm commented on GitHub (Jan 22, 2024): I have exaclty the same behavior, like my screenshot 3 days ago, I tried to clean the cache, different browser... weird EDIT : On the red card the number is colored right, but not the task progression : ![vikunja_card_color2](https://github.com/go-vikunja/frontend/assets/23743455/5fbfe8f5-ae26-4f33-b787-151f978b3039) @kolaente
Author
Owner

@kolaente commented on GitHub (Jan 26, 2024):

Pushed another fix for this in cd0149ef69. Please check again with the next unstable build (in ~45min)

@kolaente commented on GitHub (Jan 26, 2024): Pushed another fix for this in cd0149ef69a58e2c00e68541f3c26745fee218df. Please check again with the next unstable build (in ~45min)
Author
Owner

@hugosxm commented on GitHub (Jan 30, 2024):

I still see color mismatches, I tried all the predefined colors, the first one, the blue is not working by the way.

Maybe I should try with a fresh install ? Each time I tested, I tested on my existing vikunja as I tought it is safe because it is the frontend part not the api part...

vikunja_card_color

@hugosxm commented on GitHub (Jan 30, 2024): I still see color mismatches, I tried all the predefined colors, the first one, the blue is not working by the way. Maybe I should try with a fresh install ? Each time I tested, I tested on my existing vikunja as I tought it is safe because it is the frontend part not the api part... ![vikunja_card_color](https://github.com/go-vikunja/frontend/assets/23743455/6ce02bed-3d63-4c97-9f46-50ef77d6c46a)
Author
Owner

@kolaente commented on GitHub (Jan 30, 2024):

Does it work on try?

@kolaente commented on GitHub (Jan 30, 2024): Does it work on [try](https://try.vikunja.io)?
Author
Owner

@hugosxm commented on GitHub (Jan 30, 2024):

@kolaente yes it works on the demo ! I forgot that vikunja have this public demo ...

But the blue color is not working on the demo too ^^ if you selected blue the card stay uncolored

EDIT : I switched my own vikunja from 0.22.0 to 0.22.1 ( as I saw the release just now ) on BOTH api and frontend and now it works ! But still no blue card ...

@hugosxm commented on GitHub (Jan 30, 2024): @kolaente yes it works on the demo ! I forgot that vikunja have this public demo ... But the blue color is not working on the demo too ^^ if you selected blue the card stay uncolored EDIT : I switched my own vikunja from 0.22.0 to 0.22.1 ( as I saw the release just now ) on BOTH api and frontend and now it works ! But still no blue card ...
Author
Owner

@kolaente commented on GitHub (Feb 6, 2024):

@hugosxm The blue color issue should be fixed in 6cc75928d8

@kolaente commented on GitHub (Feb 6, 2024): @hugosxm The blue color issue should be fixed in https://github.com/go-vikunja/frontend/commit/6cc75928d8ffd0ecf6ba082425e80bfff8519bbe
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#1894