github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2025-12-05 19:16:51 -06:00
Code Issues 219 Packages Projects Releases 2 Wiki Activity

[PR #1738] fix(task): remove duplicate close button on mobile task detail #1721

New Issue
Open
opened 2025-11-01 21:26:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-01 21:26:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1738
Author: @kolaente
Created: 10/31/2025
Status: 🔄 Open

Base: main ← Head: claude/fix-duplicate-close-button-mobile-011CUfbqZNZYoki8vXzWMGFS

📝 Commits (1)

  • 982090d fix: remove duplicate close button on mobile task detail view

📊 Changes

1 file changed (+2 additions, -3 deletions)

View changed files

📝 frontend/src/views/tasks/TaskDetailView.vue (+2 -3)

📄 Description

When viewing a task in modal mode on mobile, both a back button and a close button were displayed, causing confusion. The back button condition !isModal || isMobile meant it would show on mobile even in modal mode.

This fix changes the back button to only display when not in modal mode (!isModal), ensuring only the close button appears when viewing tasks in a modal on mobile devices.

Also removed the now-unused isMobile variable and its import.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1738 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 10/31/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `claude/fix-duplicate-close-button-mobile-011CUfbqZNZYoki8vXzWMGFS` --- ### 📝 Commits (1) - [`982090d`](https://github.com/go-vikunja/vikunja/commit/982090d428902d3abd94e87f345a73350bfc00b8) fix: remove duplicate close button on mobile task detail view ### 📊 Changes **1 file changed** (+2 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/views/tasks/TaskDetailView.vue` (+2 -3) </details> ### 📄 Description When viewing a task in modal mode on mobile, both a back button and a close button were displayed, causing confusion. The back button condition `!isModal || isMobile` meant it would show on mobile even in modal mode. This fix changes the back button to only display when not in modal mode (`!isModal`), ensuring only the close button appears when viewing tasks in a modal on mobile devices. Also removed the now-unused `isMobile` variable and its import. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the
pull-request
 label 2025-11-01 21:26:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/caldav
area/filters
area/frontend
area/gantt
area/internal-code
area/typesense
bug
changes requested
confirmed
dependencies
enhancement
good first issue
help wanted
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
question
security
support
upstream issue
waiting for reply
wontfix
No Label
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#1721
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?