github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-11 00:11:54 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #1477] [MERGED] fix: initialize task positions for saved filters #1521

New Issue
Closed
opened 2025-11-01 21:21:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-01 21:21:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1477
Author: @kolaente
Created: 9/11/2025
Status: ✅ Merged
Merged: 9/11/2025
Merged by: @kolaente

Base: main ← Head: codex/fix-task-position-initialization-in-saved-filters

📝 Commits (2)

📊 Changes

2 files changed (+129 additions, -17 deletions)

View changed files

➕ pkg/models/saved_filter_positions_test.go (+93 -0)
📝 pkg/models/saved_filters.go (+36 -17)

📄 Description

Summary

  • ensure SavedFilter.Update assigns real task positions when adding tasks
  • compute positions for tasks added by cron and addTaskToFilter
  • add regression tests for saved-filter task positions
  • recalc saved-filter task positions once per view using RecalculateTaskPositions

Resolves https://github.com/go-vikunja/vikunja/issues/724

https://chatgpt.com/codex/tasks/task_e_68c2d62fce60832291f1528ae330046b

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1477 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 9/11/2025 **Status:** ✅ Merged **Merged:** 9/11/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `codex/fix-task-position-initialization-in-saved-filters` --- ### 📝 Commits (2) - [`ef6154e`](https://github.com/go-vikunja/vikunja/commit/ef6154ee151d80c1096f3261d2c4eb112f97731c) fix: recalc saved filter positions - [`20b670e`](https://github.com/go-vikunja/vikunja/commit/20b670ec9a98eedc69e603a4608f5b62612b948f) fix lint ### 📊 Changes **2 files changed** (+129 additions, -17 deletions) <details> <summary>View changed files</summary> ➕ `pkg/models/saved_filter_positions_test.go` (+93 -0) 📝 `pkg/models/saved_filters.go` (+36 -17) </details> ### 📄 Description ## Summary - ensure SavedFilter.Update assigns real task positions when adding tasks - compute positions for tasks added by cron and addTaskToFilter - add regression tests for saved-filter task positions - recalc saved-filter task positions once per view using RecalculateTaskPositions Resolves https://github.com/go-vikunja/vikunja/issues/724 ------ https://chatgpt.com/codex/tasks/task_e_68c2d62fce60832291f1528ae330046b --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-01 21:21:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#1521
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?