github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-03-11 17:48:44 -05:00
Code Issues 219 Packages Projects Releases 2 Wiki Activity

[PR #1461] [MERGED] fix(task): ensure done_at can never be set by user #1511

New Issue
Closed
opened 2025-11-01 21:21:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-01 21:21:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1461
Author: @kolaente
Created: 9/10/2025
Status: ✅ Merged
Merged: 9/11/2025
Merged by: @kolaente

Base: main ← Head: codex/fix-inconsistent-done_at-field-behavior

📝 Commits (6)

📊 Changes

3 files changed (+101 additions, -4 deletions)

View changed files

📝 pkg/models/bulk_task_test.go (+18 -0)
📝 pkg/models/tasks.go (+11 -4)
📝 pkg/models/tasks_test.go (+72 -0)

📄 Description

Summary

  • prevent clients from overriding task completion timestamps
  • add tests ensuring done_at is set by server for single and bulk updates

Resolves https://github.com/go-vikunja/vikunja/issues/1458

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1461 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 9/10/2025 **Status:** ✅ Merged **Merged:** 9/11/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `codex/fix-inconsistent-done_at-field-behavior` --- ### 📝 Commits (6) - [`dafe077`](https://github.com/go-vikunja/vikunja/commit/dafe07797b623ebab9b8cdb7346be6c3da5beda4) fix: enforce system-controlled done_at - [`729b379`](https://github.com/go-vikunja/vikunja/commit/729b379cfea1b2276641cc81ad9deaec11f8e27f) Remove note about system-controlled fields in Update - [`3d9158c`](https://github.com/go-vikunja/vikunja/commit/3d9158c85c933521fe2a8bd0bb5e1ec44a7f61ae) fix - [`4c82986`](https://github.com/go-vikunja/vikunja/commit/4c82986956aa588a87ceccc71fd47d422e2bf623) adjust tests - [`0dde278`](https://github.com/go-vikunja/vikunja/commit/0dde27847acc60da20931c07e6ca344ef4849933) fix stuff - [`3de4a98`](https://github.com/go-vikunja/vikunja/commit/3de4a98912b51c7546184996fa6f309b79018e0d) fix for repeating tasks ### 📊 Changes **3 files changed** (+101 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `pkg/models/bulk_task_test.go` (+18 -0) 📝 `pkg/models/tasks.go` (+11 -4) 📝 `pkg/models/tasks_test.go` (+72 -0) </details> ### 📄 Description ## Summary - prevent clients from overriding task completion timestamps - add tests ensuring done_at is set by server for single and bulk updates Resolves https://github.com/go-vikunja/vikunja/issues/1458 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-01 21:21:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/caldav
area/filters
area/frontend
area/gantt
area/internal-code
area/typesense
bug
changes requested
confirmed
dependencies
enhancement
good first issue
help wanted
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#1511
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?