github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-03-22 13:05:43 -05:00
Code Issues 447 Packages Projects Releases 9 Wiki Activity

[PR #1456] [MERGED] feat: share logic for bulk update #1509

New Issue
Closed
opened 2025-11-01 21:21:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-01 21:21:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1456
Author: @kolaente
Created: 9/10/2025
Status: ✅ Merged
Merged: 9/10/2025
Merged by: @kolaente

Base: main ← Head: codex/implement-bulk-task-editing-endpoint

📝 Commits (4)

  • b6c73e5 fix: refine bulk task update permissions
  • 4e7ef3f fix test assertions
  • 83888f3 refactor
  • 52e4262 feat: add test for done_at validation

📊 Changes

5 files changed (+262 additions, -161 deletions)

View changed files

📝 pkg/models/bulk_task.go (+47 -76)
📝 pkg/models/bulk_task_test.go (+92 -67)
📝 pkg/models/error.go (+27 -0)
📝 pkg/models/tasks.go (+82 -18)
📝 pkg/models/tasks_test.go (+14 -0)

📄 Description

This change refactors the bulk task update logic so that it updates all fields a single task update would update as well.

Could be improved in the future so that it is more efficient, instead of calling the update function repeatedly. Right now, this reduces the complexity by a lot and it should be fast enough for most cases using this.

Resolves #1452

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1456 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 9/10/2025 **Status:** ✅ Merged **Merged:** 9/10/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `codex/implement-bulk-task-editing-endpoint` --- ### 📝 Commits (4) - [`b6c73e5`](https://github.com/go-vikunja/vikunja/commit/b6c73e519c1d00eb9148541a4c7f1855c3b840bf) fix: refine bulk task update permissions - [`4e7ef3f`](https://github.com/go-vikunja/vikunja/commit/4e7ef3f678eadca5ad217e9ade21f2f70cba76f6) fix test assertions - [`83888f3`](https://github.com/go-vikunja/vikunja/commit/83888f31b381d02dd26e39965a0702ac31ca2ee1) refactor - [`52e4262`](https://github.com/go-vikunja/vikunja/commit/52e42626fa9b1bb718e28f7e40932afafec58d0e) feat: add test for done_at validation ### 📊 Changes **5 files changed** (+262 additions, -161 deletions) <details> <summary>View changed files</summary> 📝 `pkg/models/bulk_task.go` (+47 -76) 📝 `pkg/models/bulk_task_test.go` (+92 -67) 📝 `pkg/models/error.go` (+27 -0) 📝 `pkg/models/tasks.go` (+82 -18) 📝 `pkg/models/tasks_test.go` (+14 -0) </details> ### 📄 Description This change refactors the bulk task update logic so that it updates all fields a single task update would update as well. Could be improved in the future so that it is more efficient, instead of calling the update function repeatedly. Right now, this reduces the complexity by a lot and it should be fast enough for most cases using this. Resolves #1452 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-01 21:21:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/caldav
area/filters
area/frontend
area/gantt
area/internal-code
area/typesense
bug
changes requested
confirmed
dependencies
enhancement
good first issue
help wanted
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#1509
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?