github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2025-12-05 19:16:51 -06:00
Code Issues 219 Packages Projects Releases 2 Wiki Activity

[PR #1398] feat: add independent tasks due today reminders #1468

New Issue
Open
opened 2025-11-01 21:20:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-01 21:20:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1398
Author: @kolaente
Created: 9/3/2025
Status: 🔄 Open

Base: main ← Head: codex/analyze-codebase-for-email-task-feature

📝 Commits (4)

  • 301fdfc fix: address review feedback for today reminders
  • 4cb9403 refactor: rename overdue reminders time field
  • db7de6d fix: add missing reminder translations
  • b27bd2e fix tests

📊 Changes

26 files changed (+871 additions, -169 deletions)

View changed files

➕ PLAN.md (+66 -0)
📝 config-raw.json (+7 -2)
➕ config.yml.sample (+459 -0)
📝 frontend/cypress/e2e/task/overview.spec.ts (+1 -1)
📝 frontend/src/i18n/lang/en.json (+2 -1)
📝 frontend/src/modelTypes/IUserSettings.ts (+4 -3)
📝 frontend/src/models/userSettings.ts (+2 -1)
📝 frontend/src/views/user/settings/General.vue (+24 -16)
📝 pkg/config/config.go (+3 -2)
📝 pkg/db/fixtures/tasks.yml (+11 -0)
📝 pkg/db/fixtures/users.yml (+1 -0)
📝 pkg/i18n/lang/en.json (+4 -1)
➕ pkg/migration/20250903072808.go (+40 -0)
➕ pkg/migration/20250903072809.go (+45 -0)
📝 pkg/models/label_task_test.go (+1 -1)
📝 pkg/models/label_test.go (+6 -4)
📝 pkg/models/notifications.go (+48 -54)
📝 pkg/models/project_users_test.go (+3 -2)
📝 pkg/models/task_collection_test.go (+34 -3)
📝 pkg/models/task_today_reminder.go (+46 -37)

...and 6 more files

📄 Description

Summary

  • rename overdue reminder implementation to task_today_reminder and keep userWithTasks structure for overdue and due-today tasks
  • add test fixture task #47 after task #46 and remove redundant config default
  • drop unused Cypress test for today reminders

Testing

  • mage lint:fix (fails: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0))
  • mage test:feature (fails: go: no such tool "covdata" )
  • pnpm lint:fix
  • pnpm lint:styles:fix

https://chatgpt.com/codex/tasks/task_e_68b75b6d6c508322b23c24e9f3e6e26d

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1398 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 9/3/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `codex/analyze-codebase-for-email-task-feature` --- ### 📝 Commits (4) - [`301fdfc`](https://github.com/go-vikunja/vikunja/commit/301fdfcfcaaa58ab5545c98ea0ef0e1561492a19) fix: address review feedback for today reminders - [`4cb9403`](https://github.com/go-vikunja/vikunja/commit/4cb9403e59e61fa734751d3fc26215e53878fdd8) refactor: rename overdue reminders time field - [`db7de6d`](https://github.com/go-vikunja/vikunja/commit/db7de6d0d6032b09422b0d3a974e6c26cf4c1ae5) fix: add missing reminder translations - [`b27bd2e`](https://github.com/go-vikunja/vikunja/commit/b27bd2e36dc5b9ed8f6af0212068c9956083511b) fix tests ### 📊 Changes **26 files changed** (+871 additions, -169 deletions) <details> <summary>View changed files</summary> ➕ `PLAN.md` (+66 -0) 📝 `config-raw.json` (+7 -2) ➕ `config.yml.sample` (+459 -0) 📝 `frontend/cypress/e2e/task/overview.spec.ts` (+1 -1) 📝 `frontend/src/i18n/lang/en.json` (+2 -1) 📝 `frontend/src/modelTypes/IUserSettings.ts` (+4 -3) 📝 `frontend/src/models/userSettings.ts` (+2 -1) 📝 `frontend/src/views/user/settings/General.vue` (+24 -16) 📝 `pkg/config/config.go` (+3 -2) 📝 `pkg/db/fixtures/tasks.yml` (+11 -0) 📝 `pkg/db/fixtures/users.yml` (+1 -0) 📝 `pkg/i18n/lang/en.json` (+4 -1) ➕ `pkg/migration/20250903072808.go` (+40 -0) ➕ `pkg/migration/20250903072809.go` (+45 -0) 📝 `pkg/models/label_task_test.go` (+1 -1) 📝 `pkg/models/label_test.go` (+6 -4) 📝 `pkg/models/notifications.go` (+48 -54) 📝 `pkg/models/project_users_test.go` (+3 -2) 📝 `pkg/models/task_collection_test.go` (+34 -3) 📝 `pkg/models/task_today_reminder.go` (+46 -37) _...and 6 more files_ </details> ### 📄 Description ## Summary - rename overdue reminder implementation to task_today_reminder and keep userWithTasks structure for overdue and due-today tasks - add test fixture task #47 after task #46 and remove redundant config default - drop unused Cypress test for today reminders ## Testing - `mage lint:fix` *(fails: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0))* - `mage test:feature` *(fails: go: no such tool "covdata" )* - `pnpm lint:fix` - `pnpm lint:styles:fix` ------ https://chatgpt.com/codex/tasks/task_e_68b75b6d6c508322b23c24e9f3e6e26d --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the
pull-request
 label 2025-11-01 21:20:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/caldav
area/filters
area/frontend
area/gantt
area/internal-code
area/typesense
bug
changes requested
confirmed
dependencies
enhancement
good first issue
help wanted
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
question
security
support
upstream issue
waiting for reply
wontfix
No Label
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#1468
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?