[PR #1124] [MERGED] fix(labels): correctly fall back to variable colors when no label color is set #1252

Closed
opened 2025-11-01 21:14:17 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1124
Author: @kolaente
Created: 7/15/2025
Status: Merged
Merged: 7/15/2025
Merged by: @kolaente

Base: mainHead: codex/fix-struct-invalid-error-when-updating-label


📝 Commits (3)

  • 60987cc fix(frontend): keep label colors api-friendly
  • ed30a95 fix: fallback to var text color
  • c7a5c14 refactor: move style computation to function

📊 Changes

5 files changed (+26 additions, -8 deletions)

View changed files

📝 frontend/src/components/tasks/partials/EditLabels.vue (+4 -2)
📝 frontend/src/components/tasks/partials/Label.vue (+4 -1)
frontend/src/composables/useLabelStyles.ts (+14 -0)
📝 frontend/src/models/label.ts (+1 -4)
📝 frontend/src/views/labels/ListLabels.vue (+3 -1)

📄 Description

Resolves https://github.com/go-vikunja/vikunja/issues/1086


https://chatgpt.com/codex/tasks/task_e_6867751462fc8322bd00be64aa159fd9


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1124 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 7/15/2025 **Status:** ✅ Merged **Merged:** 7/15/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `codex/fix-struct-invalid-error-when-updating-label` --- ### 📝 Commits (3) - [`60987cc`](https://github.com/go-vikunja/vikunja/commit/60987cc80478b799003e6e4ca9276f04a28bd132) fix(frontend): keep label colors api-friendly - [`ed30a95`](https://github.com/go-vikunja/vikunja/commit/ed30a9537fa74c1f3aba7447d4dfba8dd3f6112f) fix: fallback to var text color - [`c7a5c14`](https://github.com/go-vikunja/vikunja/commit/c7a5c14c9b067b26863b4fd16bb57801f78a6d41) refactor: move style computation to function ### 📊 Changes **5 files changed** (+26 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/tasks/partials/EditLabels.vue` (+4 -2) 📝 `frontend/src/components/tasks/partials/Label.vue` (+4 -1) ➕ `frontend/src/composables/useLabelStyles.ts` (+14 -0) 📝 `frontend/src/models/label.ts` (+1 -4) 📝 `frontend/src/views/labels/ListLabels.vue` (+3 -1) </details> ### 📄 Description Resolves https://github.com/go-vikunja/vikunja/issues/1086 ------ https://chatgpt.com/codex/tasks/task_e_6867751462fc8322bd00be64aa159fd9 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-01 21:14:17 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#1252