github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2025-12-05 19:16:51 -06:00
Code Issues 219 Packages Projects Releases 2 Wiki Activity

[PR #1085] fix(typesense): centralize sentinel and improve indexing #1218

New Issue
Open
opened 2025-11-01 21:13:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-01 21:13:30 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1085
Author: @dpschen
Created: 7/3/2025
Status: 🔄 Open

Base: main ← Head: feat/implement-typesense-null-handling-with-sentinel

📝 Commits (1)

  • f9e498a fix(typesense): centralize sentinel and improve indexing

📊 Changes

12 files changed (+190 additions, -33 deletions)

View changed files

➕ docs/null-date-sentinel.md (+15 -0)
📝 go.mod (+2 -0)
📝 go.sum (+10 -0)
📝 pkg/cmd/index.go (+1 -1)
➕ pkg/cmd/reindex_sentinel.go (+58 -0)
📝 pkg/models/listeners.go (+4 -4)
📝 pkg/models/saved_filters.go (+1 -1)
📝 pkg/models/task_search.go (+7 -3)
📝 pkg/models/task_search_bench_test.go (+1 -1)
📝 pkg/models/tasks.go (+1 -14)
📝 pkg/models/typesense.go (+27 -9)
➕ pkg/models/typesense_test.go (+63 -0)

📄 Description

  • use -1 sentinel for missing due dates when indexing tasks into Typesense
  • adjust Typesense schema to require due_date
  • add CLI command reindex-sentinel with progress bar
  • include sentinel in Typesense filter builder
  • remove fallback to DB search once Typesense is enabled
  • document the sentinel approach
  • add tests for sentinel conversion

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1085 **Author:** [@dpschen](https://github.com/dpschen) **Created:** 7/3/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feat/implement-typesense-null-handling-with-sentinel` --- ### 📝 Commits (1) - [`f9e498a`](https://github.com/go-vikunja/vikunja/commit/f9e498ac1915036d6249da427da81f9238927440) fix(typesense): centralize sentinel and improve indexing ### 📊 Changes **12 files changed** (+190 additions, -33 deletions) <details> <summary>View changed files</summary> ➕ `docs/null-date-sentinel.md` (+15 -0) 📝 `go.mod` (+2 -0) 📝 `go.sum` (+10 -0) 📝 `pkg/cmd/index.go` (+1 -1) ➕ `pkg/cmd/reindex_sentinel.go` (+58 -0) 📝 `pkg/models/listeners.go` (+4 -4) 📝 `pkg/models/saved_filters.go` (+1 -1) 📝 `pkg/models/task_search.go` (+7 -3) 📝 `pkg/models/task_search_bench_test.go` (+1 -1) 📝 `pkg/models/tasks.go` (+1 -14) 📝 `pkg/models/typesense.go` (+27 -9) ➕ `pkg/models/typesense_test.go` (+63 -0) </details> ### 📄 Description - use `-1` sentinel for missing due dates when indexing tasks into Typesense - adjust Typesense schema to require due_date - add CLI command `reindex-sentinel` with progress bar - include sentinel in Typesense filter builder - remove fallback to DB search once Typesense is enabled - document the sentinel approach - add tests for sentinel conversion --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the
pull-request
 label 2025-11-01 21:13:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/caldav
area/filters
area/frontend
area/gantt
area/internal-code
area/typesense
bug
changes requested
confirmed
dependencies
enhancement
good first issue
help wanted
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
question
security
support
upstream issue
waiting for reply
wontfix
No Label
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#1218
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?