github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 11:37:49 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #1084] [MERGED] fix(user): persist status on email updates #1217

New Issue
Closed
opened 2025-11-01 21:13:29 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-01 21:13:29 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1084
Author: @dpschen
Created: 7/3/2025
Status: ✅ Merged
Merged: 8/4/2025
Merged by: @kolaente

Base: main ← Head: feat/update-email-status-handling

📝 Commits (4)

  • cdc582a fix(user): persist status on email updates
  • 74532f4 Merge branch 'main' into feat/update-email-status-handling
  • e524dea fix test
  • ab972ff fix test

📊 Changes

6 files changed (+85 additions, -9 deletions)

View changed files

📝 pkg/user/test.go (+2 -0)
📝 pkg/user/update_email.go (+8 -6)
➕ pkg/user/update_email_test.go (+72 -0)
📝 pkg/user/user.go (+1 -1)
📝 pkg/user/user_create.go (+1 -1)
📝 pkg/user/user_email_confirm.go (+1 -1)

📄 Description

  • update email updates to persist status column before token generation
  • switch other flows from is_active to status
  • handle status when mailer is disabled
  • add unit test for status persistence

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1084 **Author:** [@dpschen](https://github.com/dpschen) **Created:** 7/3/2025 **Status:** ✅ Merged **Merged:** 8/4/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `feat/update-email-status-handling` --- ### 📝 Commits (4) - [`cdc582a`](https://github.com/go-vikunja/vikunja/commit/cdc582af56bbf9e0225839ebd2787565318c3341) fix(user): persist status on email updates - [`74532f4`](https://github.com/go-vikunja/vikunja/commit/74532f4bdbfcba3986eef935328fff9e83d8e060) Merge branch 'main' into feat/update-email-status-handling - [`e524dea`](https://github.com/go-vikunja/vikunja/commit/e524dea6c2958c7ab152669e31f08d07dab607f7) fix test - [`ab972ff`](https://github.com/go-vikunja/vikunja/commit/ab972ff998079aa5c8f6f5b435391f7a8a6badbd) fix test ### 📊 Changes **6 files changed** (+85 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `pkg/user/test.go` (+2 -0) 📝 `pkg/user/update_email.go` (+8 -6) ➕ `pkg/user/update_email_test.go` (+72 -0) 📝 `pkg/user/user.go` (+1 -1) 📝 `pkg/user/user_create.go` (+1 -1) 📝 `pkg/user/user_email_confirm.go` (+1 -1) </details> ### 📄 Description - update email updates to persist `status` column before token generation - switch other flows from `is_active` to `status` - handle status when mailer is disabled - add unit test for status persistence --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-01 21:13:29 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#1217
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?