github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 19:47:47 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #1083] [CLOSED] test(user): verify invalid deletion token #1216

New Issue
Closed
opened 2025-11-01 21:13:28 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-01 21:13:28 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1083
Author: @dpschen
Created: 7/3/2025
Status: ❌ Closed

Base: main ← Head: feat/replace-todo-with-invalid-token-error

📝 Commits (1)

  • 88d2070 test(user): verify invalid deletion token

📊 Changes

4 files changed (+60 additions, -2 deletions)

View changed files

📝 frontend/src/i18n/lang/en.json (+1 -0)
📝 pkg/user/delete.go (+1 -2)
📝 pkg/user/error.go (+23 -0)
➕ pkg/webtests/user_confirm_deletion_test.go (+35 -0)

📄 Description

  • return a clear error when confirming deletion with an invalid token
  • add english translation for deletion token error
  • test invalid token on account deletion confirmation

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1083 **Author:** [@dpschen](https://github.com/dpschen) **Created:** 7/3/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/replace-todo-with-invalid-token-error` --- ### 📝 Commits (1) - [`88d2070`](https://github.com/go-vikunja/vikunja/commit/88d2070838eb670672be4c9f8dcb6036e762d1f8) test(user): verify invalid deletion token ### 📊 Changes **4 files changed** (+60 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/i18n/lang/en.json` (+1 -0) 📝 `pkg/user/delete.go` (+1 -2) 📝 `pkg/user/error.go` (+23 -0) ➕ `pkg/webtests/user_confirm_deletion_test.go` (+35 -0) </details> ### 📄 Description - return a clear error when confirming deletion with an invalid token - add english translation for deletion token error - test invalid token on account deletion confirmation --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-01 21:13:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#1216
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?