github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-22 10:41:27 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #1034] [MERGED] fix: guard invalid user lookups #1169

New Issue
Closed
opened 2025-11-01 21:12:27 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-01 21:12:27 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1034
Author: @kolaente
Created: 6/26/2025
Status: ✅ Merged
Merged: 6/26/2025
Merged by: @kolaente

Base: main ← Head: codex/fix-user-and-owner-id-validation

📝 Commits (3)

📊 Changes

8 files changed (+38 additions, -16 deletions)

View changed files

📝 pkg/models/kanban.go (+6 -2)
📝 pkg/models/label_task.go (+3 -1)
📝 pkg/models/link_sharing.go (+3 -1)
📝 pkg/models/listeners.go (+8 -6)
📝 pkg/models/project.go (+3 -1)
📝 pkg/models/task_attachment.go (+6 -2)
📝 pkg/models/tasks.go (+6 -2)
📝 pkg/models/webhooks.go (+3 -1)

📄 Description

Might resolve https://community.vikunja.io/t/webhook-project-error/3305/26

Summary

  • avoid user lookup if doer id is invalid when reloading event data
  • handle projects with invalid owners gracefully
  • skip CreatedBy lookup for tasks when no creator is set

Testing

  • mage lint:fix

https://chatgpt.com/codex/tasks/task_e_685db7c7e45883228a48bf14522620c5

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1034 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 6/26/2025 **Status:** ✅ Merged **Merged:** 6/26/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `codex/fix-user-and-owner-id-validation` --- ### 📝 Commits (3) - [`3c6a278`](https://github.com/go-vikunja/vikunja/commit/3c6a278575591370cb2a44f01fe70559671d3da0) fix: guard invalid user lookups - [`5eedafa`](https://github.com/go-vikunja/vikunja/commit/5eedafa35775f3969fb15ab3d7f7eb89012cf912) better style - [`a5ee5fd`](https://github.com/go-vikunja/vikunja/commit/a5ee5fda3e95c4c1ae239fca95ef363ed485373d) fix: check if users exist ### 📊 Changes **8 files changed** (+38 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `pkg/models/kanban.go` (+6 -2) 📝 `pkg/models/label_task.go` (+3 -1) 📝 `pkg/models/link_sharing.go` (+3 -1) 📝 `pkg/models/listeners.go` (+8 -6) 📝 `pkg/models/project.go` (+3 -1) 📝 `pkg/models/task_attachment.go` (+6 -2) 📝 `pkg/models/tasks.go` (+6 -2) 📝 `pkg/models/webhooks.go` (+3 -1) </details> ### 📄 Description Might resolve https://community.vikunja.io/t/webhook-project-error/3305/26 ## Summary - avoid user lookup if doer id is invalid when reloading event data - handle projects with invalid owners gracefully - skip CreatedBy lookup for tasks when no creator is set ## Testing - `mage lint:fix` ------ https://chatgpt.com/codex/tasks/task_e_685db7c7e45883228a48bf14522620c5 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-01 21:12:27 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#1169
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?