github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-05 19:18:16 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

Side by Side editor feature breaks everything #108

New Issue
Closed
opened 2025-11-01 20:47:17 -05:00 by GiteaMirror · 6 comments
GiteaMirror commented 2025-11-01 20:47:17 -05:00
Owner
Copy Link

Originally created by @thelicato on GitHub (Nov 15, 2022).

Description

When using the editor (i.e. writing a description, posting a comment and so on) if I click on the "Side by side" icon it becomes full screen and it is impossible to deactivate it. The only working solution is to refresh the page.

Vikunja Frontend Version

0.20.1

Vikunja API Version

0.20.1

Browser and version

Chrome Version 107.0.5304.110 (Official Build) (64-bit)

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

Screenshot from 2022-11-15 10-47-35
Screenshot from 2022-11-15 10-47-49

Originally created by @thelicato on GitHub (Nov 15, 2022). ### Description When using the editor (i.e. writing a description, posting a comment and so on) if I click on the "Side by side" icon it becomes full screen and it is impossible to deactivate it. The only working solution is to refresh the page. ### Vikunja Frontend Version 0.20.1 ### Vikunja API Version 0.20.1 ### Browser and version Chrome Version 107.0.5304.110 (Official Build) (64-bit) ### Can you reproduce the bug on the Vikunja demo site? Yes ### Screenshots ![Screenshot from 2022-11-15 10-47-35](https://user-images.githubusercontent.com/20096272/201887173-a191f27b-4a7e-40ad-9997-cf2f8a4b6f40.png) ![Screenshot from 2022-11-15 10-47-49](https://user-images.githubusercontent.com/20096272/201887184-2518e64c-bcef-4adb-9188-19df5e10aa9f.png)
GiteaMirror added the bug label 2025-11-01 20:47:17 -05:00
GiteaMirror commented 2025-11-01 20:47:18 -05:00
Author
Owner
Copy Link

@dpschen commented on GitHub (Nov 15, 2022):

You can close it via esc.

Still not, how it should be!
The toolbar is hidden behind the navigation. Is this how you made the second screenshot @thelicato?

We are in the process of replacing our editor with TipTap (also see wip pull request: https://kolaente.dev/vikunja/frontend/pulls/2222). I guess this is an error big enough so that it makes sense to fix it before we go merge that.

To reveal the editor navigation, we only have to move it down, that's an easy fix.

But if you click then the Side-by-side button again it stays in fullscreen but switches to the single column (markdown) mode.
If you click the button another time you go back to the described two column fullscreen.

@kolaente Do you remember the user was intended to get out of this mode (aside of esc)? Was there a close button or something?

Also I'm not sure if opening the editor in fullscreen is what one would suspect to happen when clicking on the side-by-side button.

@dpschen commented on GitHub (Nov 15, 2022): You can close it via <kbd>esc</kbd>. Still not, how it should be! The toolbar is hidden behind the navigation. Is this how you made the second screenshot @thelicato? We are in the process of replacing our editor with [TipTap](https://tiptap.dev/) (also see wip pull request: https://kolaente.dev/vikunja/frontend/pulls/2222). I guess this is an error big enough so that it makes sense to fix it before we go merge that. To reveal the editor navigation, we only have to move it down, that's an easy fix. But if you click then the Side-by-side button again it stays in fullscreen but switches to the single column (markdown) mode. If you click the button another time you go back to the described two column fullscreen. @kolaente Do you remember the user was intended to get out of this mode (aside of <kbd>esc</kbd>)? Was there a close button or something? Also I'm not sure if opening the editor in fullscreen is what one would suspect to happen when clicking on the side-by-side button.
GiteaMirror commented 2025-11-01 20:47:18 -05:00
Author
Owner
Copy Link

@thelicato commented on GitHub (Nov 15, 2022):

The second screenshot is taken after clicking on the Side by side button inside a Task modal. Yep it's a bit confusing for the user

@thelicato commented on GitHub (Nov 15, 2022): The second screenshot is taken after clicking on the _Side by side_ button inside a Task modal. Yep it's a bit confusing for the user
GiteaMirror commented 2025-11-01 20:47:18 -05:00
Author
Owner
Copy Link

@dpschen commented on GitHub (Nov 15, 2022):

Ahh, that's why the main navigation doesn't overlay the editor menu.

@dpschen commented on GitHub (Nov 15, 2022): Ahh, that's why the main navigation doesn't overlay the editor menu.
GiteaMirror commented 2025-11-01 20:47:19 -05:00
Author
Owner
Copy Link

@kolaente commented on GitHub (Nov 15, 2022):

@kolaente Do you remember the user was intended to get out of this mode (aside of esc)? Was there a close button or something?

AFAIK there should be a button in the toolbar to get out again. I didn't implement this though, that's a feature of the editor.

The fix should be to make the toolbar visible. If that's too much work I think we can get by with just removing the button in the editor toolbar alltogether as we'll replace the editor anyway.

@kolaente commented on GitHub (Nov 15, 2022): > @kolaente Do you remember the user was intended to get out of this mode (aside of esc)? Was there a close button or something? AFAIK there should be a button in the toolbar to get out again. I didn't implement this though, that's a feature of the editor. The fix should be to make the toolbar visible. If that's too much work I think we can get by with just removing the button in the editor toolbar alltogether as we'll replace the editor anyway.
GiteaMirror commented 2025-11-01 20:47:19 -05:00
Author
Owner
Copy Link

@dpschen commented on GitHub (Nov 15, 2022):

I found a setting in EasyMDE (our current editor) which lets you disable the going to fullscreen in the side-by-side mode.
I made a pull request, where you can check out in the preview how that would look:
https://kolaente.dev/vikunja/frontend/pulls/2710

What do you think? Should we disable fullscreen?

@dpschen commented on GitHub (Nov 15, 2022): I found a setting in EasyMDE (our current editor) which lets you disable the going to fullscreen in the side-by-side mode. I made a pull request, where you can check out in the preview how that would look: https://kolaente.dev/vikunja/frontend/pulls/2710 What do you think? Should we disable fullscreen?
GiteaMirror commented 2025-11-01 20:47:19 -05:00
Author
Owner
Copy Link

@kolaente commented on GitHub (Nov 16, 2022):

Fixed in 98b38af43c

@kolaente commented on GitHub (Nov 16, 2022): Fixed in https://github.com/go-vikunja/frontend/commit/98b38af43c3acc9822f167ebca295f5aecb4908d
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#108
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?