github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-03-09 07:13:35 -05:00
Code Issues 219 Packages Projects Releases 2 Wiki Activity

[PR #930] [MERGED] feat(auth): require auth to fetch avatars #1071

New Issue
Closed
opened 2025-11-01 21:10:24 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-01 21:10:24 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/930
Author: @kolaente
Created: 6/12/2025
Status: ✅ Merged
Merged: 6/14/2025
Merged by: @kolaente

Base: main ← Head: codex/require-authentication-for-avatar-fetching

📝 Commits (9)

  • bf51ea9 fix: clean up avatar auth implementation
  • 51dc1a0 fmt
  • 9ccbcd5 cleanup
  • c59d4ec fix: create user so that the avatar request does not fail
  • a2af204 fix: do not reload avatar when link share auth
  • 63cc02a feat: create predictable link share usernames
  • 20ef300 fix: link share test fixture
  • 5eb7b8c feat: add link share username validation
  • 1a9f256 fix: handle svg avatars specifically

📊 Changes

15 files changed (+204 additions, -37 deletions)

View changed files

📝 .vscode/settings.json (+1 -1)
📝 frontend/cypress/e2e/sharing/linkShare.spec.ts (+2 -0)
📝 frontend/src/components/misc/User.vue (+10 -3)
📝 frontend/src/components/tasks/partials/Comments.vue (+25 -5)
📝 frontend/src/models/user.ts (+35 -2)
📝 frontend/src/services/abstractService.ts (+11 -0)
📝 frontend/src/stores/auth.ts (+10 -14)
📝 pkg/models/link_sharing.go (+5 -3)
📝 pkg/models/link_sharing_test.go (+33 -0)
📝 pkg/models/task_collection_test.go (+5 -4)
📝 pkg/routes/routes.go (+3 -3)
📝 pkg/user/error.go (+23 -0)
📝 pkg/user/user_create.go (+9 -0)
📝 pkg/user/user_test.go (+26 -0)
📝 pkg/user/validator.go (+6 -2)

📄 Description

Summary

  • require authentication when fetching avatars
  • remove unused helper and add caching for avatar blobs
  • expose authenticated avatar endpoint in routes

Testing

  • mage lint:fix (fails: signal interrupt)
  • pnpm lint:fix

https://chatgpt.com/codex/tasks/task_e_684875c90408832297e411b920d030db

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/930 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 6/12/2025 **Status:** ✅ Merged **Merged:** 6/14/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `codex/require-authentication-for-avatar-fetching` --- ### 📝 Commits (9) - [`bf51ea9`](https://github.com/go-vikunja/vikunja/commit/bf51ea9f1e5329a7f7ba140cb7463dc8c6b006b0) fix: clean up avatar auth implementation - [`51dc1a0`](https://github.com/go-vikunja/vikunja/commit/51dc1a052a89db9ab9227f066463107242147aa4) fmt - [`9ccbcd5`](https://github.com/go-vikunja/vikunja/commit/9ccbcd51397e1e64b02100147cd1e2f3657c997a) cleanup - [`c59d4ec`](https://github.com/go-vikunja/vikunja/commit/c59d4ec72380e702fc43a42edbc04a778563fbc5) fix: create user so that the avatar request does not fail - [`a2af204`](https://github.com/go-vikunja/vikunja/commit/a2af2046134bc6e09ca16d6aa6b02e6e541a1a98) fix: do not reload avatar when link share auth - [`63cc02a`](https://github.com/go-vikunja/vikunja/commit/63cc02aa995ee1a8b1e0f9df72f516574893983f) feat: create predictable link share usernames - [`20ef300`](https://github.com/go-vikunja/vikunja/commit/20ef300778bdcacff578c274ea724898b5d74ea2) fix: link share test fixture - [`5eb7b8c`](https://github.com/go-vikunja/vikunja/commit/5eb7b8c274d2a3dd7fc0cef337d5b47c0e0b73d4) feat: add link share username validation - [`1a9f256`](https://github.com/go-vikunja/vikunja/commit/1a9f256005efd0973c6e7ca7e994085f9e33c51c) fix: handle svg avatars specifically ### 📊 Changes **15 files changed** (+204 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `.vscode/settings.json` (+1 -1) 📝 `frontend/cypress/e2e/sharing/linkShare.spec.ts` (+2 -0) 📝 `frontend/src/components/misc/User.vue` (+10 -3) 📝 `frontend/src/components/tasks/partials/Comments.vue` (+25 -5) 📝 `frontend/src/models/user.ts` (+35 -2) 📝 `frontend/src/services/abstractService.ts` (+11 -0) 📝 `frontend/src/stores/auth.ts` (+10 -14) 📝 `pkg/models/link_sharing.go` (+5 -3) 📝 `pkg/models/link_sharing_test.go` (+33 -0) 📝 `pkg/models/task_collection_test.go` (+5 -4) 📝 `pkg/routes/routes.go` (+3 -3) 📝 `pkg/user/error.go` (+23 -0) 📝 `pkg/user/user_create.go` (+9 -0) 📝 `pkg/user/user_test.go` (+26 -0) 📝 `pkg/user/validator.go` (+6 -2) </details> ### 📄 Description ## Summary - require authentication when fetching avatars - remove unused helper and add caching for avatar blobs - expose authenticated avatar endpoint in routes ## Testing - `mage lint:fix` *(fails: signal interrupt)* - `pnpm lint:fix` ------ https://chatgpt.com/codex/tasks/task_e_684875c90408832297e411b920d030db --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-01 21:10:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/caldav
area/filters
area/frontend
area/gantt
area/internal-code
area/typesense
bug
changes requested
confirmed
dependencies
enhancement
good first issue
help wanted
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#1071
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?