github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-03-12 10:04:48 -05:00
Code Issues 219 Packages Projects Releases 2 Wiki Activity

[PR #871] [CLOSED] fix: many type errors #1017

New Issue
Closed
opened 2025-11-01 21:09:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-01 21:09:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/871
Author: @kolaente
Created: 6/4/2025
Status: ❌ Closed

Base: main ← Head: codex/fix-all-type-errors

📝 Commits (1)

  • e14bd81 fix: address ts errors in user and team views

📊 Changes

21 files changed (+193 additions, -151 deletions)

View changed files

📝 frontend/src/App.vue (+2 -2)
📝 frontend/src/components/base/BaseButton.story.vue (+2 -2)
📝 frontend/src/components/base/Expandable.vue (+27 -23)
📝 frontend/src/helpers/parseDateOrNull.ts (+1 -1)
📝 frontend/src/modelTypes/IAvatar.ts (+1 -1)
📝 frontend/src/modelTypes/ICaldavToken.ts (+7 -2)
📝 frontend/src/modelTypes/IUser.ts (+3 -2)
📝 frontend/src/models/apiTokenModel.ts (+3 -3)
📝 frontend/src/views/teams/EditTeam.vue (+20 -19)
📝 frontend/src/views/teams/ListTeams.vue (+2 -1)
📝 frontend/src/views/user/Login.vue (+13 -6)
📝 frontend/src/views/user/PasswordReset.vue (+8 -7)
📝 frontend/src/views/user/Register.vue (+10 -8)
📝 frontend/src/views/user/RequestPasswordReset.vue (+4 -3)
📝 frontend/src/views/user/settings/ApiTokens.vue (+27 -24)
📝 frontend/src/views/user/settings/Avatar.vue (+24 -19)
📝 frontend/src/views/user/settings/Caldav.vue (+5 -2)
📝 frontend/src/views/user/settings/General.vue (+30 -23)
📝 frontend/src/views/user/settings/TOTP.vue (+1 -1)
📝 frontend/tsconfig.app.json (+2 -1)

...and 1 more files

📄 Description

Summary

  • fix Register view error handling
  • type credentials in Login view
  • type Teams listing
  • refine team member management and imports
  • handle PasswordReset casting

Testing

  • pnpm run typecheck (fails: numerous remaining type errors)

https://chatgpt.com/codex/tasks/task_e_684064a140208322be9922555b661bc9

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/871 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 6/4/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `codex/fix-all-type-errors` --- ### 📝 Commits (1) - [`e14bd81`](https://github.com/go-vikunja/vikunja/commit/e14bd817bcfdb10311f591009c94b34cfa65c3e8) fix: address ts errors in user and team views ### 📊 Changes **21 files changed** (+193 additions, -151 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/App.vue` (+2 -2) 📝 `frontend/src/components/base/BaseButton.story.vue` (+2 -2) 📝 `frontend/src/components/base/Expandable.vue` (+27 -23) 📝 `frontend/src/helpers/parseDateOrNull.ts` (+1 -1) 📝 `frontend/src/modelTypes/IAvatar.ts` (+1 -1) 📝 `frontend/src/modelTypes/ICaldavToken.ts` (+7 -2) 📝 `frontend/src/modelTypes/IUser.ts` (+3 -2) 📝 `frontend/src/models/apiTokenModel.ts` (+3 -3) 📝 `frontend/src/views/teams/EditTeam.vue` (+20 -19) 📝 `frontend/src/views/teams/ListTeams.vue` (+2 -1) 📝 `frontend/src/views/user/Login.vue` (+13 -6) 📝 `frontend/src/views/user/PasswordReset.vue` (+8 -7) 📝 `frontend/src/views/user/Register.vue` (+10 -8) 📝 `frontend/src/views/user/RequestPasswordReset.vue` (+4 -3) 📝 `frontend/src/views/user/settings/ApiTokens.vue` (+27 -24) 📝 `frontend/src/views/user/settings/Avatar.vue` (+24 -19) 📝 `frontend/src/views/user/settings/Caldav.vue` (+5 -2) 📝 `frontend/src/views/user/settings/General.vue` (+30 -23) 📝 `frontend/src/views/user/settings/TOTP.vue` (+1 -1) 📝 `frontend/tsconfig.app.json` (+2 -1) _...and 1 more files_ </details> ### 📄 Description ## Summary - fix Register view error handling - type credentials in Login view - type Teams listing - refine team member management and imports - handle PasswordReset casting ## Testing - `pnpm run typecheck` *(fails: numerous remaining type errors)* ------ https://chatgpt.com/codex/tasks/task_e_684064a140208322be9922555b661bc9 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-01 21:09:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/caldav
area/filters
area/frontend
area/gantt
area/internal-code
area/typesense
bug
changes requested
confirmed
dependencies
enhancement
good first issue
help wanted
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#1017
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?