github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 03:27:53 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2541] [MERGED] feat: add inline PDF viewer for task attachments #10067

New Issue
Closed
opened 2026-04-23 09:22:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 09:22:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2541
Author: @kolaente
Created: 4/4/2026
Status: ✅ Merged
Merged: 4/4/2026
Merged by: @kolaente

Base: main ← Head: claude/add-pdf-viewer-Rtms5

📝 Commits (5)

  • 63eeb69 feat: add inline PDF viewer for task attachments
  • 239660a fix: leave space for modal close button in PDF viewer
  • e5be3e0 fix: make PDF viewer modal full height
  • 94b00a1 fix: restrict thumbnail blob loading to image attachments
  • c48746d fix: height

📊 Changes

4 files changed (+55 additions, -7 deletions)

View changed files

📝 frontend/src/components/misc/Icon.ts (+2 -0)
📝 frontend/src/components/tasks/partials/Attachments.vue (+28 -3)
📝 frontend/src/components/tasks/partials/FilePreview.vue (+15 -3)
📝 frontend/src/models/attachment.ts (+10 -1)

📄 Description

Click a PDF attachment to view it in a modal using the browser's built-in
PDF viewer (via iframe + blob URL), similar to how image attachments are
already previewed inline. No new dependencies required.

  • Add canPreviewImage() and canPreviewPdf() helpers to attachment model
  • Show PDF-specific icon in file preview thumbnails
  • Register faFilePdf FontAwesome icon
  • Restrict cover image selection to image attachments only

https://claude.ai/code/session_01XDYUghqViTPzNiLLwYH4JL

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2541 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 4/4/2026 **Status:** ✅ Merged **Merged:** 4/4/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `claude/add-pdf-viewer-Rtms5` --- ### 📝 Commits (5) - [`63eeb69`](https://github.com/go-vikunja/vikunja/commit/63eeb694e9da2af97d8b5a7b49e09e7b1d2ea4e6) feat: add inline PDF viewer for task attachments - [`239660a`](https://github.com/go-vikunja/vikunja/commit/239660a2a9617d2757726a0664400cc5e366ce9b) fix: leave space for modal close button in PDF viewer - [`e5be3e0`](https://github.com/go-vikunja/vikunja/commit/e5be3e0af0c54285b37c49496aaff79b49219d4b) fix: make PDF viewer modal full height - [`94b00a1`](https://github.com/go-vikunja/vikunja/commit/94b00a157b355ade9a1952874c255b8a2a60e02c) fix: restrict thumbnail blob loading to image attachments - [`c48746d`](https://github.com/go-vikunja/vikunja/commit/c48746da87fe6431fb22c607528f7b462917be98) fix: height ### 📊 Changes **4 files changed** (+55 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/misc/Icon.ts` (+2 -0) 📝 `frontend/src/components/tasks/partials/Attachments.vue` (+28 -3) 📝 `frontend/src/components/tasks/partials/FilePreview.vue` (+15 -3) 📝 `frontend/src/models/attachment.ts` (+10 -1) </details> ### 📄 Description Click a PDF attachment to view it in a modal using the browser's built-in PDF viewer (via iframe + blob URL), similar to how image attachments are already previewed inline. No new dependencies required. - Add canPreviewImage() and canPreviewPdf() helpers to attachment model - Show PDF-specific icon in file preview thumbnails - Register faFilePdf FontAwesome icon - Restrict cover image selection to image attachments only https://claude.ai/code/session_01XDYUghqViTPzNiLLwYH4JL --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 09:22:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#10067
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?