github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-07-15 22:32:29 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2519] [MERGED] fix(overview): respect task permission when showing checkbox #10047

New Issue
Closed
opened 2026-04-23 09:22:11 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 09:22:11 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2519
Author: @tink-bot
Created: 4/2/2026
Status: ✅ Merged
Merged: 4/3/2026
Merged by: @kolaente

Base: main ← Head: fix/read-only-checkbox-overview

📝 Commits (3)

  • 7eefbed fix(overview): disable checkbox for read-only tasks on overview page
  • 7f63207 test(e2e): add test for read-only checkbox on overview page
  • 4426d5c feat: add tooltip to readonly checkbox explaining why it's not clickable

📊 Changes

4 files changed (+99 additions, -6 deletions)

View changed files

📝 frontend/src/components/tasks/partials/SingleTaskInProject.vue (+10 -6)
📝 frontend/src/i18n/lang/en.json (+1 -0)
📝 frontend/src/views/tasks/ShowTasks.vue (+2 -0)
➕ frontend/tests/e2e/task/read-only-checkbox-overview.spec.ts (+86 -0)

📄 Description

Passes canMarkAsDone prop to SingleTaskInProject in ShowTasks.vue based on task.maxPermission, so read-only tasks no longer show an interactive checkbox on the Overview page.

Fixes #2399

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2519 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 4/2/2026 **Status:** ✅ Merged **Merged:** 4/3/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix/read-only-checkbox-overview` --- ### 📝 Commits (3) - [`7eefbed`](https://github.com/go-vikunja/vikunja/commit/7eefbedb883f45e72bf6def6965ce30e1c58ea7b) fix(overview): disable checkbox for read-only tasks on overview page - [`7f63207`](https://github.com/go-vikunja/vikunja/commit/7f6320765502035643d6d9e7b559b2f8e23719f5) test(e2e): add test for read-only checkbox on overview page - [`4426d5c`](https://github.com/go-vikunja/vikunja/commit/4426d5c9f07671c475db8a4514db0423f44926e0) feat: add tooltip to readonly checkbox explaining why it's not clickable ### 📊 Changes **4 files changed** (+99 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/tasks/partials/SingleTaskInProject.vue` (+10 -6) 📝 `frontend/src/i18n/lang/en.json` (+1 -0) 📝 `frontend/src/views/tasks/ShowTasks.vue` (+2 -0) ➕ `frontend/tests/e2e/task/read-only-checkbox-overview.spec.ts` (+86 -0) </details> ### 📄 Description Passes `canMarkAsDone` prop to `SingleTaskInProject` in `ShowTasks.vue` based on `task.maxPermission`, so read-only tasks no longer show an interactive checkbox on the Overview page. Fixes #2399 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 09:22:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#10047
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?