github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-04-29 11:00:07 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

fix(backgrounds): avoid integer overflow in max size calculation

Browse Source 
Keep maxSize as uint64 and cast safely when comparing with
resp.ContentLength to avoid potential integer overflow.
This commit is contained in:
kolaente
2026-02-04 19:48:05 +01:00
parent ea78e87147
commit 56a0ea44cf
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/modules/background/unsplash/unsplash.go
View File

@@ -281,19 +281,19 @@ func (p *Provider) Set(s *xorm.Session, image *background.Image, project *models
log.Debugf("Pinged unsplash download endpoint for photo %s", image.ID)
// Enforce max file size to prevent OOM from unexpectedly large responses
maxSize := int64(config.GetMaxFileSizeInMBytes() * 1024 * 1024)
if resp.ContentLength > maxSize {
maxSize := config.GetMaxFileSizeInMBytes() * 1024 * 1024
if resp.ContentLength > 0 && uint64(resp.ContentLength) > maxSize {
return files.ErrFileIsTooLarge{Size: uint64(resp.ContentLength)}
}
// Buffer the response body so we have a seekable reader for S3 uploads.
// Use LimitReader as a safety net in case Content-Length was missing or inaccurate.
limitedReader := io.LimitReader(resp.Body, maxSize+1)
limitedReader := io.LimitReader(resp.Body, int64(maxSize)+1) // #nosec G115 -- maxSize is configured, not user input
bodyBytes, err := io.ReadAll(limitedReader)
if err != nil {
return err
}
if int64(len(bodyBytes)) > maxSize {
if uint64(len(bodyBytes)) > maxSize {
return files.ErrFileIsTooLarge{Size: uint64(len(bodyBytes))}
}