github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-04-30 16:28:23 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

fix(attachments): use mime.FormatMediaType for Content-Disposition header

Browse Source
This commit is contained in:
kolaente
2026-02-24 20:38:40 +01:00
parent 7e7e778d49
commit 329c07f24b
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/routes/api/v1/task_attachment.go
View File

@@ -19,6 +19,7 @@ package v1
import ( import (
"errors" "errors"
"io" "io"
"mime"
"net/http" "net/http"
"strconv" "strconv"
"strings" "strings"
@@ -210,9 +211,9 @@ func GetTaskAttachment(c *echo.Context) error {
mimeToReturn = "application/octet-stream" mimeToReturn = "application/octet-stream"
} }
filename := strings.ReplaceAll(taskAttachment.File.Name, `"`, `\"`) c.Response().Header().Set("Content-Disposition", mime.FormatMediaType("attachment", map[string]string{
"filename": taskAttachment.File.Name,
c.Response().Header().Set("Content-Disposition", "attachment; filename=\""+filename+"\"") }))
c.Response().Header().Set("Content-Type", mimeToReturn) c.Response().Header().Set("Content-Type", mimeToReturn)
c.Response().Header().Set("Content-Length", strconv.FormatUint(taskAttachment.File.Size, 10)) c.Response().Header().Set("Content-Length", strconv.FormatUint(taskAttachment.File.Size, 10))
c.Response().Header().Set("Last-Modified", taskAttachment.File.Created.UTC().Format(http.TimeFormat)) c.Response().Header().Set("Last-Modified", taskAttachment.File.Created.UTC().Format(http.TimeFormat))