github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-04-30 08:25:58 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

fix: commit transaction in session cleanup cron

Browse Source 
RegisterSessionCleanupCron opens a transaction via db.NewSession() but
never calls s.Commit(). The deferred s.Close() auto-rolls-back, making
the DELETE a no-op. Add the missing commit.
This commit is contained in:
kolaente
2026-02-25 10:48:21 +01:00
parent 2f680d041c
commit 107a92f573
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/models/sessions.go
View File

@@ -230,6 +230,10 @@ func RegisterSessionCleanupCron() {
if deleted > 0 { if deleted > 0 {
log.Debugf(logPrefix+"Deleted %d stale sessions", deleted) log.Debugf(logPrefix+"Deleted %d stale sessions", deleted)
} }
if err := s.Commit(); err != nil {
log.Errorf(logPrefix+"Could not commit: %s", err)
}
}) })
if err != nil { if err != nil {
log.Fatalf("Could not register session cleanup cron: %s", err) log.Fatalf("Could not register session cleanup cron: %s", err)