mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-08-24 23:22:58 -05:00
[GH-ISSUE #26] get_org_collection_detail() errors with "Collection not found" when User isn't directly assigned to collection #8821
Reference in New Issue
Block a user
Originally created by @mprasil on GitHub (May 19, 2018).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/26
The function doesn't work for
UserOrganizationwithaccess_all, forAdminorOwnerthat doesn't have directCollectionUsermapping.This is because we only use
Collection::find_by_uuid_and_user()in the handler, but the above users don't necessarily need to have access allowed for specificCollectionas they can generally access anyCollectionwithinOrganization. We need to check whether that isn't the case before returning error.@dani-garcia commented on GitHub (May 21, 2018):
This should be fixed by your PR #28 so I'm closing it. Thanks!