github-starred/vaultwarden
2
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden.git synced 2026-05-23 08:32:45 -05:00
Code Issues 307 Packages Projects Releases 83 Wiki Activity

[PR #5188] [MERGED] Some more authrequest changes #8512

New Issue
Closed
opened 2026-04-16 12:28:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 12:28:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/5188
Author: @dani-garcia
Created: 11/12/2024
Status: ✅ Merged
Merged: 11/15/2024
Merged by: @dani-garcia

Base: main ← Head: authrequest_changes

📝 Commits (2)

  • 71eaddf Some more authrequest changes
  • 6d0446f Merge branch 'main' into authrequest_changes

📊 Changes

2 files changed (+12 additions, -2 deletions)

View changed files

📝 src/api/core/accounts.rs (+8 -2)
📝 src/api/identity.rs (+4 -0)

📄 Description

  • Previously we weren't setting the response date anywhere, it doesn't seem used but might as well return it just in case.
  • If an authentication request was approved already, we don't allow to do it again. This is to match with what Bitwarden is doing, though I don't think there's a way to actually do it or exploit it somehow.
  • Added an explicit time limit for the auth requests, previously we relied on our scheduled job to clean them up, and a user could technically disable that.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/5188 **Author:** [@dani-garcia](https://github.com/dani-garcia) **Created:** 11/12/2024 **Status:** ✅ Merged **Merged:** 11/15/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `authrequest_changes` --- ### 📝 Commits (2) - [`71eaddf`](https://github.com/dani-garcia/vaultwarden/commit/71eaddf1bd45957431bf342b979e8d3235ae2ccc) Some more authrequest changes - [`6d0446f`](https://github.com/dani-garcia/vaultwarden/commit/6d0446f32c14e8d2ade4967fd4ff8fe3f5bcffd2) Merge branch 'main' into authrequest_changes ### 📊 Changes **2 files changed** (+12 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/accounts.rs` (+8 -2) 📝 `src/api/identity.rs` (+4 -0) </details> ### 📄 Description - Previously we weren't setting the response date anywhere, it doesn't seem used but might as well return it just in case. - If an authentication request was approved already, we don't allow to do it again. This is to match with what Bitwarden is doing, though I don't think there's a way to actually do it or exploit it somehow. - Added an explicit time limit for the auth requests, previously we relied on our scheduled job to clean them up, and a user could technically disable that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 12:28:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
better for forum
bug
documentation
duplicate
enhancement
future Vault
good first issue
help wanted
low priority
notes
pull-request
Mirrored from GitHub Pull Request
 question
SSO
Third party
troubleshooting
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#8512
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?