[PR #2729] [MERGED] Change the handling of login errors. #8075

New Issue

Closed

opened 2026-04-16 12:14:34 -05:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-04-16 12:14:34 -05:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/2729
Author: @BlackDex
Created: 9/6/2022
Status: ✅ Merged
Merged: 9/8/2022
Merged by: @dani-garcia

Base: main ← Head: vw-admin-updates

---

📝 Commits (1)

• 5a05139 Change the handling of login errors.

📊 Changes

6 files changed (+262 additions, -1205 deletions)

View changed files

📝 src/api/admin.rs (+29 -17)
📝 src/api/web.rs (+2 -2)
📝 src/static/scripts/bootstrap.css (+120 -1103)
📝 src/static/scripts/jquery-3.6.1.slim.js (+109 -81)
📝 src/static/templates/admin/organizations.hbs (+1 -1)
📝 src/static/templates/admin/users.hbs (+1 -1)

📄 Description

Previously FlashMessage was used to provide an error message during login.
This PR changes that flow to not use redirect for this, but renders the HTML and responds using the correct status code where needed. This should solve some issues which were reported in the past.

Thanks to @RealOrangeOne, for initiating this with a PR.

Fixes #2448
Fixes #2712
Closes #2715

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/2729 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 9/6/2022 **Status:** ✅ Merged **Merged:** 9/8/2022 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `vw-admin-updates` --- ### 📝 Commits (1) - [`5a05139`](https://github.com/dani-garcia/vaultwarden/commit/5a05139efe484b37edbc2db6eb618676d26f3723) Change the handling of login errors. ### 📊 Changes **6 files changed** (+262 additions, -1205 deletions) <details> <summary>View changed files</summary> 📝 `src/api/admin.rs` (+29 -17) 📝 `src/api/web.rs` (+2 -2) 📝 `src/static/scripts/bootstrap.css` (+120 -1103) 📝 `src/static/scripts/jquery-3.6.1.slim.js` (+109 -81) 📝 `src/static/templates/admin/organizations.hbs` (+1 -1) 📝 `src/static/templates/admin/users.hbs` (+1 -1) </details> ### 📄 Description Previously FlashMessage was used to provide an error message during login. This PR changes that flow to not use redirect for this, but renders the HTML and responds using the correct status code where needed. This should solve some issues which were reported in the past. Thanks to @RealOrangeOne, for initiating this with a PR. Fixes #2448 Fixes #2712 Closes #2715 --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-04-16 12:14:34 -05:00

GiteaMirror closed this issue 2026-04-16 12:14:35 -05:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

revert-7033-patch-1

cached-config-operations

test_dylint

1.36.0

1.35.8

1.35.7

1.35.6

1.35.5

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

GiteaMirror ninjasurge

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#8075