[PR #6880] Fix favicon fetching to check all icon links instead of just the first one #7496

New Issue

Open

opened 2026-03-07 21:18:30 -06:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-03-07 21:18:30 -06:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/6880
Author: @Shocker
Created: 2/27/2026
Status: 🔄 Open

Base: main ← Head: fix-all-icons

---

📝 Commits (4)

• b7acf97 Fix favicon fetching to check all icon links instead of just the first one
• 0d68502 revert max icons limit removal
• 757b6fc optimize code
• e235aea code formatting

📊 Changes

1 file changed (+16 additions, -3 deletions)

View changed files

📝 src/api/icons.rs (+16 -3)

📄 Description

Fix logic in download_icon(), got broken (most likely accidentally) in 27dc67fadd (diff-c0f730ed83eb02623c5c9bde35b0366115b8961fb596c27f98613140cba6d2a7L714) which caused the downloader to stop after first error

Also don't limit max checked icons to 5, allow all icons in the list

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/6880 **Author:** [@Shocker](https://github.com/Shocker) **Created:** 2/27/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix-all-icons` --- ### 📝 Commits (4) - [`b7acf97`](https://github.com/dani-garcia/vaultwarden/commit/b7acf975ba5625bc4e48c4ba7358e736544aa9cd) Fix favicon fetching to check all icon links instead of just the first one - [`0d68502`](https://github.com/dani-garcia/vaultwarden/commit/0d685026eb655b2caf021298014682cc8cea7024) revert max icons limit removal - [`757b6fc`](https://github.com/dani-garcia/vaultwarden/commit/757b6fcacfcb21ad220fca4b6180c4ee53ad18a6) optimize code - [`e235aea`](https://github.com/dani-garcia/vaultwarden/commit/e235aea44d73a867f3e1066241f7c54d03dc5caa) code formatting ### 📊 Changes **1 file changed** (+16 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/api/icons.rs` (+16 -3) </details> ### 📄 Description Fix logic in `download_icon()`, got broken (most likely accidentally) in https://github.com/dani-garcia/vaultwarden/commit/27dc67fadd3d45b9f7d8d37407cef9453b8f5802#diff-c0f730ed83eb02623c5c9bde35b0366115b8961fb596c27f98613140cba6d2a7L714 which caused the downloader to stop after first error ~~Also don't limit max checked icons to 5, allow all icons in the list~~ --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-03-07 21:18:30 -06:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

revert-7033-patch-1

cached-config-operations

test_dylint

1.36.0

1.35.8

1.35.7

1.35.6

1.35.5

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

GiteaMirror ninjasurge

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#7496