[PR #6733] [MERGED] use email instead of empty name for webauhn #7471

New Issue

GiteaMirror · 2026-03-07T21:18:08-06:00

GiteaMirror commented

2026-03-07 21:18:08 -06:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/6733
Author: @stefan0xC
Created: 1/18/2026
Status: ✅ Merged
Merged: 1/18/2026
Merged by: @BlackDex

Base: main ← Head: fix-issue-adding-with-webauthn

📝 Commits (2)

63f47df if empty use email instead of name for webauhn
59560e3 use email as display name if name is empty

📊 Changes

4 files changed (+13 additions, -4 deletions)

View changed files

📝 src/api/core/organizations.rs (+1 -1)
📝 src/api/core/two_factor/webauthn.rs (+1 -1)
📝 src/api/identity.rs (+2 -2)
📝 src/db/models/user.rs (+9 -0)

📄 Description

it seems like the passkey registration currently fails if a user's name is empty
b2cd556f3e/src/api/core/two_factor/webauthn.rs (L144-L149)

since the user_display_name is optional and not used for authentication using the email here should be okay.

this should fix #6732

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/6733 **Author:** [@stefan0xC](https://github.com/stefan0xC) **Created:** 1/18/2026 **Status:** ✅ Merged **Merged:** 1/18/2026 **Merged by:** [@BlackDex](https://github.com/BlackDex) **Base:** `main` ← **Head:** `fix-issue-adding-with-webauthn` --- ### 📝 Commits (2) - [`63f47df`](https://github.com/dani-garcia/vaultwarden/commit/63f47df942dfa29750825065130329236471b302) if empty use email instead of name for webauhn - [`59560e3`](https://github.com/dani-garcia/vaultwarden/commit/59560e378aa522b6bdffe030283b0fdd11677040) use email as display name if name is empty ### 📊 Changes **4 files changed** (+13 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/organizations.rs` (+1 -1) 📝 `src/api/core/two_factor/webauthn.rs` (+1 -1) 📝 `src/api/identity.rs` (+2 -2) 📝 `src/db/models/user.rs` (+9 -0) </details> ### 📄 Description it seems like the passkey registration currently fails if a user's name is empty https://github.com/dani-garcia/vaultwarden/blob/b2cd556f3e79673d3eff1dac9b7402c18aa69d69/src/api/core/two_factor/webauthn.rs#L144-L149 since the `user_display_name` [is optional](https://docs.rs/webauthn-rs/latest/webauthn_rs/struct.Webauthn.html#method.start_passkey_registration) and not used for authentication using the email here should be okay. this should fix #6732 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-03-07 21:18:08 -06:00

GiteaMirror closed this issue

2026-03-07 21:18:09 -06:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#7471